From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8WI2-0007hc-Tf for qemu-devel@nongnu.org; Wed, 29 Jan 2014 09:38:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8WHy-0004TJ-8s for qemu-devel@nongnu.org; Wed, 29 Jan 2014 09:38:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11135) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8WHy-0004Ss-1C for qemu-devel@nongnu.org; Wed, 29 Jan 2014 09:38:50 -0500 Message-ID: <52E90BB6.1070503@redhat.com> Date: Wed, 29 Jan 2014 07:09:58 -0700 From: Eric Blake MIME-Version: 1.0 References: <1390984843-2101-1-git-send-email-famz@redhat.com> <1390984843-2101-4-git-send-email-famz@redhat.com> In-Reply-To: <1390984843-2101-4-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x51JuuGnXCVlBQLm7P8XR5sC3smlD2i6f" Subject: Re: [Qemu-devel] [PATCH 3/4] qemu-iotests: Allow caller to disable underscore convertion for qmp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --x51JuuGnXCVlBQLm7P8XR5sC3smlD2i6f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/29/2014 01:40 AM, Fam Zheng wrote: s/convertion/conversion/ in the subject > QMP command "block_set_io_throttle" expects underscores in parameters > instead of dashes: {iops,bps}_{rd,wr,max}. >=20 > Add optional argument conv_keys (defaults to True, backward compatible)= , > it will be used in IO throttling test case. >=20 > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/iotests.py | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 You know, it might be nice to get the '-'/'_' looseness into QMP itself when invoked via JSON strings over the monitor, rather than just the testsuite wrapper, since we're already inconsistent in several commands. But that's a bigger project for another day. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --x51JuuGnXCVlBQLm7P8XR5sC3smlD2i6f Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS6Qu2AAoJEKeha0olJ0Nqr84H/i7jcDjD/kYSSk/8KutYVIqr rjUOVn1XNZgMzgd9/Fq3cYKWGJ4jJ5RTgFRCtZJcJpBatsTOe/XnJ3re9H2KvvDs kXQnJjiz1i7zoHEa3PzkcikmuGThvjaMYvhj2LVxCpWNbCcxfJ7jrjAdWaDWKbhf 51TyCqhRpmiaHn3tbGOSBN1PCWjgZsFXJELWv2+nV9zRq8pJE7gg52hEOz6LbGl2 751V+x/JwCy8EWrXaTUetBSdJbrlTgzTj6YnJ2k/KzObmtAilXQwyJbmOErX9ubB YdZUtPCCZBlm3ZYS0dMJc3bJeOZd+8xyfszuee3XvNR8F0nndCDiCWyEEGX2sRE= =HOHQ -----END PGP SIGNATURE----- --x51JuuGnXCVlBQLm7P8XR5sC3smlD2i6f--