From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8Vzt-0002SR-2b for qemu-devel@nongnu.org; Wed, 29 Jan 2014 09:20:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8Vzo-0005zD-EJ for qemu-devel@nongnu.org; Wed, 29 Jan 2014 09:20:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8Vzo-0005wO-6J for qemu-devel@nongnu.org; Wed, 29 Jan 2014 09:20:04 -0500 Message-ID: <52E90E03.7050801@redhat.com> Date: Wed, 29 Jan 2014 15:19:47 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1390890126-17377-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1390890126-17377-9-git-send-email-qiaonuohan@cn.fujitsu.com> In-Reply-To: <1390890126-17377-9-git-send-email-qiaonuohan@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 08/13] dump: add API to write dump header List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qiaonuohan Cc: stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, anderson@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp, afaerber@suse.de On 01/28/14 07:22, qiaonuohan wrote: > the functions are used to write header of kdump-compressed format to vmcore. > Header of kdump-compressed format includes: > 1. common header: DiskDumpHeader32 / DiskDumpHeader64 > 2. sub header: KdumpSubHeader32 / KdumpSubHeader64 > 3. extra information: only elf notes here > > Signed-off-by: Qiao Nuohan > Reviewed-by: Laszlo Ersek > --- > dump.c | 223 +++++++++++++++++++++++++++++++++++++++++++++++++ > include/sysemu/dump.h | 96 +++++++++++++++++++++ > 2 files changed, 319 insertions(+), 0 deletions(-) Thanks for fixing the four incorrect uses of "dh->block_size" in v7. Reviewed-by: Laszlo Ersek