From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8WJ5-0000c9-BX for qemu-devel@nongnu.org; Wed, 29 Jan 2014 09:40:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8WJ0-0004l4-QD for qemu-devel@nongnu.org; Wed, 29 Jan 2014 09:39:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8WJ0-0004kr-JE for qemu-devel@nongnu.org; Wed, 29 Jan 2014 09:39:54 -0500 Message-ID: <52E912AA.207@redhat.com> Date: Wed, 29 Jan 2014 15:39:38 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1390890126-17377-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1390890126-17377-12-git-send-email-qiaonuohan@cn.fujitsu.com> In-Reply-To: <1390890126-17377-12-git-send-email-qiaonuohan@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 11/13] dump: add API to write dump pages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qiaonuohan Cc: stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, anderson@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp, afaerber@suse.de On 01/28/14 07:22, qiaonuohan wrote: > functions are used to write page to vmcore. vmcore is written page by page. > page desc is used to store the information of a page, including a page's size, > offset, compression format, etc. > > Signed-off-by: Qiao Nuohan > Reviewed-by: Laszlo Ersek > --- > dump.c | 231 +++++++++++++++++++++++++++++++++++++++++++++++++ > include/sysemu/dump.h | 7 ++ > 2 files changed, 238 insertions(+), 0 deletions(-) Again, I checked the differences with v7, and looked at my comments for v7. Good job. My R-b stands. Thanks Laszlo