From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8WOT-0003Ky-Pe for qemu-devel@nongnu.org; Wed, 29 Jan 2014 09:45:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8WOP-00073n-03 for qemu-devel@nongnu.org; Wed, 29 Jan 2014 09:45:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8WOO-000734-CQ for qemu-devel@nongnu.org; Wed, 29 Jan 2014 09:45:28 -0500 Message-ID: <52E913FD.80105@redhat.com> Date: Wed, 29 Jan 2014 15:45:17 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1390890126-17377-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1390890126-17377-13-git-send-email-qiaonuohan@cn.fujitsu.com> In-Reply-To: <1390890126-17377-13-git-send-email-qiaonuohan@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 12/13] dump: make kdump-compressed format available for 'dump-guest-memory' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qiaonuohan Cc: stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, anderson@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp, afaerber@suse.de On 01/28/14 07:22, qiaonuohan wrote: > Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed > format. The command's usage: > > dump [-p] protocol [begin] [length] [format] > > 'format' is used to specified the format of vmcore and can be: > 1. 'elf': ELF format, without compression > 2. 'kdump-zlib': kdump-compressed format, with zlib-compressed > 3. 'kdump-lzo': kdump-compressed format, with lzo-compressed > 4. 'kdump-snappy': kdump-compressed format, with snappy-compressed > Without 'format' being set, it is same as 'elf'. And if non-elf format is > specified, paging and filter is not allowed. > > Note: > 1. The kdump-compressed format is readable only with the crash utility and > makedumpfile, and it can be smaller than the ELF format because of the > compression support. > 2. The kdump-compressed format is the 6th edition. > > Signed-off-by: Qiao Nuohan > --- > dump.c | 131 +++++++++++++++++++++++++++++++++++++++++++++++++++--- > hmp.c | 5 ++- > qapi-schema.json | 25 ++++++++++- > qmp-commands.hx | 7 ++- > 4 files changed, 158 insertions(+), 10 deletions(-) Reviewed-by: Laszlo Ersek