From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8XNG-0007So-8J for qemu-devel@nongnu.org; Wed, 29 Jan 2014 10:48:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8XNB-0003qV-Am for qemu-devel@nongnu.org; Wed, 29 Jan 2014 10:48:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8XNB-0003q9-2l for qemu-devel@nongnu.org; Wed, 29 Jan 2014 10:48:17 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0TFmF8e000880 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Jan 2014 10:48:15 -0500 Message-ID: <52E922BD.5060704@redhat.com> Date: Wed, 29 Jan 2014 08:48:13 -0700 From: Eric Blake MIME-Version: 1.0 References: <1390994251-21768-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1390994251-21768-1-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nUQ9Sf0utmRiISwqc1MvTfXXxnxXRQBuT" Subject: Re: [Qemu-devel] [PATCH] QMP: allow JSON dict arguments in qmp-shell List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nUQ9Sf0utmRiISwqc1MvTfXXxnxXRQBuT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/29/2014 04:17 AM, Stefan Hajnoczi wrote: > qmp-shell hides the QMP wire protocol JSON encoding from the user. Mos= t > of the time this is helpful and makes the command-line human-friendly. >=20 > Some QMP commands take a dict as an argument. In order to express this= > we need to revert back to JSON notation. >=20 > This patch allows JSON dict arguments in qmp-shell so commands like > blockdev-add and nbd-server-start can be invoked: >=20 > (QEMU) blockdev-add options=3D{"driver":"file","id":"drive1",...} >=20 > Note that spaces are not allowed since str.split() is used to break up > the command-line arguments first. >=20 > Signed-off-by: Stefan Hajnoczi > --- > scripts/qmp/qmp-shell | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nUQ9Sf0utmRiISwqc1MvTfXXxnxXRQBuT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS6SK9AAoJEKeha0olJ0NqgZYH/1WezCoY83Cg/JkBlVMbwkVw M1Ds778pEtY17oqEyl+Jv39SuJX9kO75L3j2oIc9Q+t8TdMY6u5jRbqvDhTFQUE3 aAHAY3TfU8LCq7ZYdentqxB7R6vkWJCC0cCkpcOMIPmCjOna9X54uS1H3dpDS9Ao oR+gHGe8mzZEcutaCOlH2CTfQt6unR0Txh23AuscZ2HhzEk8QzaCY2DB0g/Ipqqh B1w9PhO3ojz9f5stC8MsjftevC33ZDAjG4BetFlAcxERK5SiQIul4F7xb1F4Yv3o cyggE/QkWglIjqjjCUlriz1FoFcIbc+ua+1PBhn0bIsKbbU91Lg3RAxqhh7pucE= =fyCV -----END PGP SIGNATURE----- --nUQ9Sf0utmRiISwqc1MvTfXXxnxXRQBuT--