From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8sMR-0007cI-QQ for qemu-devel@nongnu.org; Thu, 30 Jan 2014 09:13:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8sMM-0008Uc-K2 for qemu-devel@nongnu.org; Thu, 30 Jan 2014 09:12:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8sMM-0008UW-CF for qemu-devel@nongnu.org; Thu, 30 Jan 2014 09:12:50 -0500 Message-ID: <52EA5DD0.9080605@redhat.com> Date: Thu, 30 Jan 2014 15:12:32 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1391087394-17914-1-git-send-email-pbonzini@redhat.com> <1391087394-17914-8-git-send-email-pbonzini@redhat.com> <52EA5D37.4070209@redhat.com> In-Reply-To: <52EA5D37.4070209@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/12] qapi: add human mode to StringOutputVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: armbru@redhat.com, afaerber@suse.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 30/01/2014 15:09, Eric Blake ha scritto: | Also, I like how your int printout was both decimal and hex; but | here you are throwing away information (and the bigger the number, | the more we lose as to how much got rounded away). I'd rather see | this as: | | "%0.03f%c (%llu)" | | so that we also have access to the unrounded exact amount. Perhaps the other way round (since hex is in parentheses)? This patch is just moving the code from qdev-properties.c. I agree with all your suggestion, but I'd prefer to tackle it as follow-ups or as patch 13/12. There are other problems, like 512MB printed as 0.500G (which is correct but looks weird). Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS6l3QAAoJEBvWZb6bTYbyiSAQAIUXn6u0GTdSI6KbWxF1hOpC nXno3OekuKomBMPZxUYzXKztwz3LhKKrPpuFHPpcIXvdIENZ7tmzTAoJFaUWCvIl R4wCPpNRiSAI5wrF8CnqPzirsc+9SlKrFCqP+mjwYQ56vGhmKcvzT0uAlLdHMOyB dn1g3PH2z8RNKSf1WxCViRwgHrSBa+w/ZjWrVQ8yEJHfBPTlQNA/x+cKKBcIQA5v SmYGUSCWj84cgEs9o9psLefxkSHyzWN+OoH1zU8VL5qegwFeQYGbHC8Q2zlM6hZO G1EtSwEknhPPTOP7+muRgNZaVaZtBi4irkZ677OtdXgrudeGaSlHnVsuYJQ72+tv B2A6DuFq4kdLB3eV/+FPnpZk1ky896nDguFuj2A8Yo7SJr88JszcI/OAosW0mF6d cML2NEt2AbwMUccbpr43qmkiLDKN0G1MIN4BVAukSGCdQfU5X6DRWWZIuicKzBbf VPYjK7puI57wC8L2Xjj8fTW6PbBG09R6IJuDvnYLRubY48qTQupOLlxx16sw61EV 450s+QkZmRTPP3GmwfsNiz+/rDlpqNB/iWnVFrek3K9Lsz0eM/CNYqiyG+LUVBCB e9D2ktLZ2mmKahiwQY4lUP4UYFjHLwhYly+OefznhYq/gKthnQD3jNaHtf3ZkNaW HO4JZAjvTsFddSr7cCTD =LRTe -----END PGP SIGNATURE-----