From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55771) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8sTt-0003P0-Bd for qemu-devel@nongnu.org; Thu, 30 Jan 2014 09:20:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8sTo-0002wN-1O for qemu-devel@nongnu.org; Thu, 30 Jan 2014 09:20:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8sTn-0002w9-OE for qemu-devel@nongnu.org; Thu, 30 Jan 2014 09:20:31 -0500 Message-ID: <52EA5FAC.9090608@redhat.com> Date: Thu, 30 Jan 2014 07:20:28 -0700 From: Eric Blake MIME-Version: 1.0 References: <1391087394-17914-1-git-send-email-pbonzini@redhat.com> <1391087394-17914-8-git-send-email-pbonzini@redhat.com> <52EA5D37.4070209@redhat.com> <52EA5DD0.9080605@redhat.com> In-Reply-To: <52EA5DD0.9080605@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SgSbB25pm0R0phNdI0R3hGXP1pXrrbOAA" Subject: Re: [Qemu-devel] [PATCH 07/12] qapi: add human mode to StringOutputVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SgSbB25pm0R0phNdI0R3hGXP1pXrrbOAA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/30/2014 07:12 AM, Paolo Bonzini wrote: > Il 30/01/2014 15:09, Eric Blake ha scritto: > | Also, I like how your int printout was both decimal and hex; but > | here you are throwing away information (and the bigger the number, > | the more we lose as to how much got rounded away). I'd rather see > | this as: > | > | "%0.03f%c (%llu)" > | > | so that we also have access to the unrounded exact amount. >=20 > Perhaps the other way round (since hex is in parentheses)? Indeed, exact(human) is better than human(exact). >=20 > This patch is just moving the code from qdev-properties.c. I agree > with all your suggestion, but I'd prefer to tackle it as follow-ups or > as patch 13/12. There are other problems, like 512MB printed as > 0.500G (which is correct but looks weird). Sure - if you post 13/12, then I'm fine with this one having: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SgSbB25pm0R0phNdI0R3hGXP1pXrrbOAA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS6l+sAAoJEKeha0olJ0NqB5kH+wcWOIWoHYDcCfcIKQrwGmoF YZs+DDWofgQV7+7BYspM1VGEoJf+3WpqDKom9Cnx+VGUQRH9gVY8D9e2ORVCon06 kU+u5X+9APLY7slaRDqNNa06mrqnjGTflS0kqw+0lCV79qZiUV915ETYeaP+JE/Y B2VwiAAViUn5dvo2/zaAehqe/9aiKS6qonAJFZ9dcnQNuGtqFgyT+Je8yfLBrvo0 zrN3V9xqq0BNSPp/wdg6tBLemsvJw0BtjX+deii557WsQ/oRMITHAfAa9DoGFHOF MLtmWq6JffJn5o6u0Nr4Z07MH3RoQH6m3D1ic4DljP2d9+hPWNYymRxCOrIkkQ8= =BoNq -----END PGP SIGNATURE----- --SgSbB25pm0R0phNdI0R3hGXP1pXrrbOAA--