From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: handle "rechs" translation option
Date: Thu, 30 Jan 2014 15:44:58 +0100 [thread overview]
Message-ID: <52EA656A.3000604@redhat.com> (raw)
In-Reply-To: <8761p1bkoi.fsf@blackfin.pond.sub.org>
Il 30/01/2014 15:37, Markus Armbruster ha scritto:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> The rechs translation option is so obscure that we support it but do
>
> "Support" is a rather strong word:
>
> $ git-grep -i rechs
> include/hw/block/block.h:#define BIOS_ATA_TRANSLATION_RECHS 4
As Stefan said, all we do is pass the info to the BIOS.
> The right way to control IDE geometry translation is ide-hd property
> bios-chs-trans. Unfortunately, you missed that one entirely. Have a
> gander at bios_chs_trans_table[] in hw/core/qdev-properties.c.
This one is handled by the other series I sent today. That's how I
found it.
> We also don't let the user ask for BIOS_ATA_TRANSLATION_LARGE. Its only
> source is hd_geometry_guess(). I have no idea whether any user would
> want to set it. But that applies to "rechs", too :)
Yeah, you are right that this patch should cover "large" as well. Will
send v2.
Paolo
next prev parent reply other threads:[~2014-01-30 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 13:08 [Qemu-devel] [PATCH] block: handle "rechs" translation option Paolo Bonzini
2014-01-30 14:37 ` Markus Armbruster
2014-01-30 14:44 ` Paolo Bonzini [this message]
2014-01-30 14:39 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EA656A.3000604@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).