* [Qemu-devel] [PATCH] libcacard: Don't link with all libraries QEMU links to
@ 2014-01-30 13:56 Christophe Fergeau
2014-01-30 14:53 ` Alon Levy
0 siblings, 1 reply; 2+ messages in thread
From: Christophe Fergeau @ 2014-01-30 13:56 UTC (permalink / raw)
To: qemu-devel
As described in https://bugzilla.redhat.com/show_bug.cgi?id=987441 ,
libcacard currently links to all the libraries QEMU is linking to,
including glusterfs libraries, libiscsi, ... libcacard does not need all of
these. This patch ensures it's only linked with the libraries it needs.
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
---
libcacard/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libcacard/Makefile b/libcacard/Makefile
index 4d15da4..6b06448 100644
--- a/libcacard/Makefile
+++ b/libcacard/Makefile
@@ -25,7 +25,7 @@ vscclient$(EXESUF): libcacard/vscclient.o libcacard.la
libcacard.la: LDFLAGS += -rpath $(libdir) -no-undefined \
-export-syms $(SRC_PATH)/libcacard/libcacard.syms
-libcacard.la: LIBS += $(libcacard_libs)
+libcacard.la: LIBS = $(libcacard_libs)
libcacard.la: $(libcacard-lobj-y)
$(call LINK,$^)
--
1.8.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] libcacard: Don't link with all libraries QEMU links to
2014-01-30 13:56 [Qemu-devel] [PATCH] libcacard: Don't link with all libraries QEMU links to Christophe Fergeau
@ 2014-01-30 14:53 ` Alon Levy
0 siblings, 0 replies; 2+ messages in thread
From: Alon Levy @ 2014-01-30 14:53 UTC (permalink / raw)
To: Christophe Fergeau, qemu-devel
On 01/30/2014 03:56 PM, Christophe Fergeau wrote:
Acked-by: Alon Levy <alevy@redhat.com>
> As described in https://bugzilla.redhat.com/show_bug.cgi?id=987441 ,
> libcacard currently links to all the libraries QEMU is linking to,
> including glusterfs libraries, libiscsi, ... libcacard does not need all of
> these. This patch ensures it's only linked with the libraries it needs.
>
> Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
> ---
> libcacard/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libcacard/Makefile b/libcacard/Makefile
> index 4d15da4..6b06448 100644
> --- a/libcacard/Makefile
> +++ b/libcacard/Makefile
> @@ -25,7 +25,7 @@ vscclient$(EXESUF): libcacard/vscclient.o libcacard.la
>
> libcacard.la: LDFLAGS += -rpath $(libdir) -no-undefined \
> -export-syms $(SRC_PATH)/libcacard/libcacard.syms
> -libcacard.la: LIBS += $(libcacard_libs)
> +libcacard.la: LIBS = $(libcacard_libs)
> libcacard.la: $(libcacard-lobj-y)
> $(call LINK,$^)
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-30 14:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-30 13:56 [Qemu-devel] [PATCH] libcacard: Don't link with all libraries QEMU links to Christophe Fergeau
2014-01-30 14:53 ` Alon Levy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).