From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40702)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1W8szW-00088L-0r
	for qemu-devel@nongnu.org; Thu, 30 Jan 2014 09:53:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1W8szQ-0006uY-Md
	for qemu-devel@nongnu.org; Thu, 30 Jan 2014 09:53:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:65427)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1W8szQ-0006uQ-Ee
	for qemu-devel@nongnu.org; Thu, 30 Jan 2014 09:53:12 -0500
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0UErAWo023789
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 30 Jan 2014 09:53:10 -0500
Message-ID: <52EA6752.6030404@redhat.com>
Date: Thu, 30 Jan 2014 16:53:06 +0200
From: Alon Levy <alevy@redhat.com>
MIME-Version: 1.0
References: <1391090209-26451-1-git-send-email-cfergeau@redhat.com>
In-Reply-To: <1391090209-26451-1-git-send-email-cfergeau@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] libcacard: Don't link with all libraries
 QEMU links to
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christophe Fergeau <cfergeau@redhat.com>, qemu-devel@nongnu.org

On 01/30/2014 03:56 PM, Christophe Fergeau wrote:

Acked-by: Alon Levy <alevy@redhat.com>

> As described in https://bugzilla.redhat.com/show_bug.cgi?id=987441 ,
> libcacard currently links to all the libraries QEMU is linking to,
> including glusterfs libraries, libiscsi, ... libcacard does not need all of
> these. This patch ensures it's only linked with the libraries it needs.
> 
> Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
> ---
>  libcacard/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libcacard/Makefile b/libcacard/Makefile
> index 4d15da4..6b06448 100644
> --- a/libcacard/Makefile
> +++ b/libcacard/Makefile
> @@ -25,7 +25,7 @@ vscclient$(EXESUF): libcacard/vscclient.o libcacard.la
>  
>  libcacard.la: LDFLAGS += -rpath $(libdir) -no-undefined \
>  	-export-syms $(SRC_PATH)/libcacard/libcacard.syms
> -libcacard.la: LIBS += $(libcacard_libs)
> +libcacard.la: LIBS = $(libcacard_libs)
>  libcacard.la: $(libcacard-lobj-y)
>  	$(call LINK,$^)
>  
>