From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52632)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W8vR9-0003bx-DA
	for qemu-devel@nongnu.org; Thu, 30 Jan 2014 12:30:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W8vR3-0001wW-8x
	for qemu-devel@nongnu.org; Thu, 30 Jan 2014 12:29:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:40439)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W8vR2-0001wK-QZ
	for qemu-devel@nongnu.org; Thu, 30 Jan 2014 12:29:52 -0500
Message-ID: <52EA8C07.5010307@redhat.com>
Date: Thu, 30 Jan 2014 18:29:43 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1391093245-14277-1-git-send-email-marcel.a@redhat.com>	
	<1391093245-14277-5-git-send-email-marcel.a@redhat.com>	
	<52EA825D.5030900@redhat.com>
	<1391102898.2197.29.camel@localhost.localdomain>
In-Reply-To: <1391102898.2197.29.camel@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC 4/5] hw/machine: add qemu machine opts
 as properties to QemuMachineState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: peter.maydell@linaro.org, mst@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, blauwirbel@gmail.com, aliguori@amazon.com, afaerber@suse.de

Il 30/01/2014 18:28, Marcel Apfelbaum ha scritto:
>> >      QEMUMachineInitArgs args = { .machine = machine,
>> >                                   .ram_size = ram_size,
>> >                                   .boot_order = boot_order,
>> >                                   .kernel_filename = kernel_filename,
>> >                                   .kernel_cmdline = kernel_cmdline,
>> >                                   .initrd_filename = initrd_filename,
>> >                                   .cpu_model = cpu_model };
>> >      machine->init(&args);
> Sure it will be by value or... I plan to replace QEMUMachineInitArgs
> with regular QOM properties of QemuMachineState.

Yes---by value for now, then it can removed when you get to 
s/QEMUMachineInitArgs/QemuMachineState.

Including the "old" object by value BTW is how the CPU conversion 
started as well.

Paolo