From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W91aF-0000Tv-1C for qemu-devel@nongnu.org; Thu, 30 Jan 2014 19:03:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W91a7-0004ST-9K for qemu-devel@nongnu.org; Thu, 30 Jan 2014 19:03:46 -0500 Received: from e24smtp02.br.ibm.com ([32.104.18.86]:39749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W91a6-0004SH-Sb for qemu-devel@nongnu.org; Thu, 30 Jan 2014 19:03:39 -0500 Received: from /spool/local by e24smtp02.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Jan 2014 22:03:34 -0200 Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 80F5D3520027 for ; Thu, 30 Jan 2014 19:03:30 -0500 (EST) Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s0V03crQ5083160 for ; Thu, 30 Jan 2014 22:03:39 -0200 Received: from d24av04.br.ibm.com (localhost [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s0V03VaZ032520 for ; Thu, 30 Jan 2014 22:03:31 -0200 Message-ID: <52EAE852.6030007@linux.vnet.ibm.com> Date: Thu, 30 Jan 2014 22:03:30 -0200 From: Eduardo Otubo MIME-Version: 1.0 References: <52EAB5E1.70807@fobos.de> In-Reply-To: <52EAB5E1.70807@fobos.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] seccomp: add timerfd_create and timerfd_settime to the whitelist List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Felix Geyer Cc: qemu-devel@nongnu.org On 01/30/2014 06:28 PM, Felix Geyer wrote: > libusb calls timerfd_create() and timerfd_settime() when it's built with > timerfd support. > > Command to reproduce: > > -device usb-host,hostbus=1,hostaddr=3,id=hostdev0 > > Log messages: > > audit(1390730418.924:135): auid=4294967295 uid=121 gid=103 ses=4294967295 > pid=5232 comm="qemu-system-x86" sig=31 syscall=283 > compat=0 ip=0x7f2b0f4e96a7 code=0x0 > audit(1390733100.580:142): auid=4294967295 uid=121 gid=103 ses=4294967295 > pid=16909 comm="qemu-system-x86" sig=31 syscall=286 > compat=0 ip=0x7f03513a06da code=0x0 > > Reading a few hundred MB from a USB drive on x86_64 shows this syscall distribution. > Therefore the timerfd_settime priority is set to 242. > > calls syscall > --------- ---------------- > 5303600 write > 2240554 read > 2167030 ppoll > 2134828 ioctl > 704023 timerfd_settime > 689105 poll > 83122 futex > 803 writev > 476 rt_sigprocmask > 287 recvmsg > 178 brk > > Signed-off-by: Felix Geyer > --- > qemu-seccomp.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/qemu-seccomp.c b/qemu-seccomp.c > index caa926e..b00922c 100644 > --- a/qemu-seccomp.c > +++ b/qemu-seccomp.c > @@ -143,6 +143,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = { > { SCMP_SYS(getsockname), 242 }, > { SCMP_SYS(getpeername), 242 }, > { SCMP_SYS(accept4), 242 }, > + { SCMP_SYS(timerfd_settime), 242 }, > { SCMP_SYS(newfstatat), 241 }, > { SCMP_SYS(shutdown), 241 }, > { SCMP_SYS(getsockopt), 241 }, > @@ -225,7 +226,8 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = { > { SCMP_SYS(fchmod), 240 }, > { SCMP_SYS(shmget), 240 }, > { SCMP_SYS(shmat), 240 }, > - { SCMP_SYS(shmdt), 240 } > + { SCMP_SYS(shmdt), 240 }, > + { SCMP_SYS(timerfd_create), 240 } > }; > > int seccomp_start(void) > ACK -- Eduardo Otubo IBM Linux Technology Center