From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W91w9-00068b-7W for qemu-devel@nongnu.org; Thu, 30 Jan 2014 19:26:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W91w4-0001ze-Ar for qemu-devel@nongnu.org; Thu, 30 Jan 2014 19:26:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W91w4-0001za-24 for qemu-devel@nongnu.org; Thu, 30 Jan 2014 19:26:20 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0V0QJ7J022756 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 30 Jan 2014 19:26:19 -0500 Message-ID: <52EAEDA9.7070802@redhat.com> Date: Thu, 30 Jan 2014 17:26:17 -0700 From: Eric Blake MIME-Version: 1.0 References: <1390903055-479-1-git-send-email-kraxel@redhat.com> <1390903055-479-7-git-send-email-kraxel@redhat.com> In-Reply-To: <1390903055-479-7-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OxaMIlL8j84XLATS5Blgv92cnO3H4UvO8" Subject: Re: [Qemu-devel] [PATCH 06/42] input: qapi: define event types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: Markus Armbruster , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OxaMIlL8j84XLATS5Blgv92cnO3H4UvO8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/28/2014 02:56 AM, Gerd Hoffmann wrote: > Define input event types, using qapi. So we get nicely autogenerated > types for our input events. And when it comes to qmp support some day > things will be alot easier. s/alot/a lot/ >=20 > Types are modeled after the linux input layer. There are separate > event types for each value. There is a sync to indicate the end > of a event group. >=20 > Mouse events are splitted into motion events (one for each axis) and s/splitted/split/ > button events, which are grouped by sync. >=20 > Keyboard events are using the existing KeyValue type. >=20 > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 76 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 1 file changed, 76 insertions(+) > + > +## > +# @InputBtnEvent Should we spell this out? I'm okay with the abbreviation if it makes it easier to fit 80 columns, but Button is nicer to read than Btn. > + > +## > +# @InputEvent > +# > +# Input event union. > +# > +# Since: 2.0 > +## > +{ 'union' : 'InputEvent', > + 'data' : { 'key' : 'InputKeyEvent', > + 'btn' : 'InputBtnEvent', Again, should we use 'button' instead of 'btn'? As naming is cosmetic, I can live with what you have. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OxaMIlL8j84XLATS5Blgv92cnO3H4UvO8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS6u2pAAoJEKeha0olJ0NqNpoH/A7s+s7jG8WuRkBfoYec3Svg qhaKwSeQA6g1bNtbLIzDzxWc6JhMVKrkDyvTtxblqflRwwU5LL30GFTyOosz4Dq9 Dy34yTWD2infg6iVLrTZ8RQDKTwdR/zZey43wVQ7Jsug/TPaX4vIll+T2+O7c3o1 Fi3icG2LTvdS/1nGTefvcI6G8vb98dSnTNUjBRs8B3E9SsGojAQ1VD+dA3Nw0vuR BGSO/nacJdVjaW8xdL7dWq9MqJf53cXzESSro53RSgBFsW9HPYyNPSrpBtni29Bu 2Gcmy2SoHlPvYxDlYpY0L1Yc+NAaJHnGyonDjxludVkG+9RZu3+2nCimfaCQlHE= =vai+ -----END PGP SIGNATURE----- --OxaMIlL8j84XLATS5Blgv92cnO3H4UvO8--