Re: [Qemu-devel] [PATCH 07/42] input: qapi: add unmapped key

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

On 01/28/2014 02:57 AM, Gerd Hoffmann wrote:
> Simplifies building something -> QkeyCode mapping tables.
> Uninitialized entries can easily identified then.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  qapi-schema.json | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 646d64f..6af22f6 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3429,9 +3429,12 @@
>  # This is used by the send-key command.
>  #
>  # Since: 1.3.0
> +#
> +# 'unmapped' since 2.0

Typically written:

# @unmapped: no key assignment (since 2.0)
#
# Since: 1.3.0

But then again, I don't know that we have very good precedent for
extending enums and documenting just the new values, so I can live with
what you did.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]