From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W91xt-00073b-Pu for qemu-devel@nongnu.org; Thu, 30 Jan 2014 19:28:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W91xo-0002Ms-U1 for qemu-devel@nongnu.org; Thu, 30 Jan 2014 19:28:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4744) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W91xo-0002Mm-Jz for qemu-devel@nongnu.org; Thu, 30 Jan 2014 19:28:08 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0V0S7FK002109 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 30 Jan 2014 19:28:07 -0500 Message-ID: <52EAEE17.3020908@redhat.com> Date: Thu, 30 Jan 2014 17:28:07 -0700 From: Eric Blake MIME-Version: 1.0 References: <1390903055-479-1-git-send-email-kraxel@redhat.com> <1390903055-479-8-git-send-email-kraxel@redhat.com> In-Reply-To: <1390903055-479-8-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SfgJnqu3lhJgKa2MHa7e13kstVKIshQtd" Subject: Re: [Qemu-devel] [PATCH 07/42] input: qapi: add unmapped key List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: Markus Armbruster , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SfgJnqu3lhJgKa2MHa7e13kstVKIshQtd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/28/2014 02:57 AM, Gerd Hoffmann wrote: > Simplifies building something -> QkeyCode mapping tables. > Uninitialized entries can easily identified then. >=20 > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 646d64f..6af22f6 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3429,9 +3429,12 @@ > # This is used by the send-key command. > # > # Since: 1.3.0 > +# > +# 'unmapped' since 2.0 Typically written: # @unmapped: no key assignment (since 2.0) # # Since: 1.3.0 But then again, I don't know that we have very good precedent for extending enums and documenting just the new values, so I can live with what you did. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SfgJnqu3lhJgKa2MHa7e13kstVKIshQtd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS6u4XAAoJEKeha0olJ0NqvrAH/1mbaNg9lZeQL2sI3NqGdJII FU/Pz40hSNl0u0sc/aNlTqUCHibENTHy9kbwyif8G/ojriBfKGTB85HseOiHUdAJ uoLIi0gLcpmC3oDA1SAivf2/ttCl9H7jsTd1gspbcravyUxwbkGxksh6AYnnCbeJ GTE9ep9Q76nf2dfzQL//BYaNjbL7Sa6m6BGLPcjc6kf8csSk6CnvPsuRxKBaFeRj NS9rxCLBgjZSv34D5+vty9q1rgjrSWfKef+c5jD2aalUGXZlUG87HU2kSUTDY1Lt D7rcwLCfzZy1TsabqhKJoLMXGf0hcjh+OgwOm+KSqHXlXLY7jpz5lPqpCkZWCmo= =rRO2 -----END PGP SIGNATURE----- --SfgJnqu3lhJgKa2MHa7e13kstVKIshQtd--