From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9CUk-0003Kj-JE for qemu-devel@nongnu.org; Fri, 31 Jan 2014 06:42:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W9CUc-0000Wz-58 for qemu-devel@nongnu.org; Fri, 31 Jan 2014 06:42:50 -0500 Received: from mail-ee0-x233.google.com ([2a00:1450:4013:c00::233]:59581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9CUb-0000Wr-U5 for qemu-devel@nongnu.org; Fri, 31 Jan 2014 06:42:42 -0500 Received: by mail-ee0-f51.google.com with SMTP id b57so2201106eek.24 for ; Fri, 31 Jan 2014 03:42:41 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52EB8C2B.1080407@redhat.com> Date: Fri, 31 Jan 2014 12:42:35 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1391111339-6958-1-git-send-email-ehabkost@redhat.com> <1391111339-6958-4-git-send-email-ehabkost@redhat.com> In-Reply-To: <1391111339-6958-4-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [uq/master PATCH 3/7] target-i386: Move KVM default-vendor hack to instance_init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: libvir-list@redhat.com, Igor Mammedov , Jiri Denemark , =?ISO-8859-1?Q?Andreas_F=E4rber?= , kvm@vger.kernel.org Il 30/01/2014 20:48, Eduardo Habkost ha scritto: > As we will not have a cpu_x86_find_by_name() function anymore, > move the KVM default-vendor hack to instance_init. > > Unfortunately we can't move that code to class_init because it depends > on KVM being initialized. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 32 +++++++++++++++++++------------- > 1 file changed, 19 insertions(+), 13 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index be54f84..0e8812a 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -1601,18 +1601,6 @@ static int cpu_x86_find_by_name(X86CPU *cpu, x86_def_t *x86_cpu_def, > def = &builtin_x86_defs[i]; > if (strcmp(name, def->name) == 0) { > memcpy(x86_cpu_def, def, sizeof(*def)); > - /* sysenter isn't supported in compatibility mode on AMD, > - * syscall isn't supported in compatibility mode on Intel. > - * Normally we advertise the actual CPU vendor, but you can > - * override this using the 'vendor' property if you want to use > - * KVM's sysenter/syscall emulation in compatibility mode and > - * when doing cross vendor migration > - */ > - if (kvm_enabled()) { > - uint32_t ebx = 0, ecx = 0, edx = 0; > - host_cpuid(0, 0, NULL, &ebx, &ecx, &edx); > - x86_cpu_vendor_words2str(x86_cpu_def->vendor, ebx, edx, ecx); > - } > return 0; > } > } > @@ -1841,7 +1829,6 @@ static void cpu_x86_register(X86CPU *cpu, const char *name, Error **errp) > return; > } > > - object_property_set_str(OBJECT(cpu), def->vendor, "vendor", errp); > object_property_set_int(OBJECT(cpu), def->level, "level", errp); > object_property_set_int(OBJECT(cpu), def->family, "family", errp); > object_property_set_int(OBJECT(cpu), def->model, "model", errp); > @@ -1865,6 +1852,25 @@ static void cpu_x86_register(X86CPU *cpu, const char *name, Error **errp) > env->features[FEAT_KVM] |= kvm_default_features; > } > env->features[FEAT_1_ECX] |= CPUID_EXT_HYPERVISOR; > + > + /* sysenter isn't supported in compatibility mode on AMD, > + * syscall isn't supported in compatibility mode on Intel. > + * Normally we advertise the actual CPU vendor, but you can > + * override this using the 'vendor' property if you want to use > + * KVM's sysenter/syscall emulation in compatibility mode and > + * when doing cross vendor migration > + */ > + const char *vendor = def->vendor; > + char host_vendor[CPUID_VENDOR_SZ + 1]; > + if (kvm_enabled()) { > + uint32_t ebx = 0, ecx = 0, edx = 0; > + host_cpuid(0, 0, NULL, &ebx, &ecx, &edx); > + x86_cpu_vendor_words2str(host_vendor, ebx, edx, ecx); > + vendor = host_vendor; > + } > + > + object_property_set_str(OBJECT(cpu), vendor, "vendor", errp); > + > } > > X86CPU *cpu_x86_create(const char *cpu_model, DeviceState *icc_bridge, > Reviewed-by: Paolo Bonzini