From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40177)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1W9CUq-0003UQ-Fe
	for qemu-devel@nongnu.org; Fri, 31 Jan 2014 06:43:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1W9CUh-0000YZ-Ul
	for qemu-devel@nongnu.org; Fri, 31 Jan 2014 06:42:56 -0500
Received: from mail-ee0-x232.google.com ([2a00:1450:4013:c00::232]:54162)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1W9CUh-0000YP-Oo
	for qemu-devel@nongnu.org; Fri, 31 Jan 2014 06:42:47 -0500
Received: by mail-ee0-f50.google.com with SMTP id d17so2195972eek.37
	for <qemu-devel@nongnu.org>; Fri, 31 Jan 2014 03:42:46 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52EB8C32.5050901@redhat.com>
Date: Fri, 31 Jan 2014 12:42:42 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1391111339-6958-1-git-send-email-ehabkost@redhat.com>
	<1391111339-6958-5-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1391111339-6958-5-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [uq/master PATCH 4/7] target-i386: Rename
 cpu_x86_register() to x86_cpu_load_def()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: libvir-list@redhat.com, Igor Mammedov <imammedo@redhat.com>, Jiri Denemark <jdenemar@redhat.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, kvm@vger.kernel.org

Il 30/01/2014 20:48, Eduardo Habkost ha scritto:
> There isn't any kind of "registration" involved in cpu_x86_register()
> anymore: it is simply looking up a CPU model name and loading the model
> definition data into the X86CPU object. Rename it to x86_cpu_load_def()
> to reflect what it does.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-i386/cpu.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 0e8812a..58b4c71 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1817,7 +1817,9 @@ static void filter_features_for_kvm(X86CPU *cpu)
>      }
>  }
>
> -static void cpu_x86_register(X86CPU *cpu, const char *name, Error **errp)
> +/* Load CPU definition for a given CPU model name
> + */
> +static void x86_cpu_load_def(X86CPU *cpu, const char *name, Error **errp)
>  {
>      CPUX86State *env = &cpu->env;
>      x86_def_t def1, *def = &def1;
> @@ -1900,7 +1902,7 @@ X86CPU *cpu_x86_create(const char *cpu_model, DeviceState *icc_bridge,
>      object_unref(OBJECT(cpu));
>  #endif
>
> -    cpu_x86_register(cpu, name, &error);
> +    x86_cpu_load_def(cpu, name, &error);
>      if (error) {
>          goto out;
>      }
>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>