From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40202) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9CUv-0003ej-WE for qemu-devel@nongnu.org; Fri, 31 Jan 2014 06:43:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W9CUn-0000Zf-G4 for qemu-devel@nongnu.org; Fri, 31 Jan 2014 06:43:01 -0500 Received: from mail-ee0-x235.google.com ([2a00:1450:4013:c00::235]:55721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9CUn-0000ZW-5d for qemu-devel@nongnu.org; Fri, 31 Jan 2014 06:42:53 -0500 Received: by mail-ee0-f53.google.com with SMTP id t10so2190826eei.26 for ; Fri, 31 Jan 2014 03:42:52 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52EB8C37.3040105@redhat.com> Date: Fri, 31 Jan 2014 12:42:47 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1391111339-6958-1-git-send-email-ehabkost@redhat.com> <1391111339-6958-7-git-send-email-ehabkost@redhat.com> In-Reply-To: <1391111339-6958-7-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [uq/master PATCH 6/7] target-i386: Rename x86_def_t to X86CPUDefinition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: libvir-list@redhat.com, Igor Mammedov , Jiri Denemark , =?ISO-8859-1?Q?Andreas_F=E4rber?= , kvm@vger.kernel.org Il 30/01/2014 20:48, Eduardo Habkost ha scritto: > As the new X86CPU subclass code is going to change lots of the code > invoving x86_def_t, let's rename the struct to match coding style first. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 5c13ed6..6659527 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -484,7 +484,7 @@ static void add_flagname_to_bitmaps(const char *flagname, > } > } > > -typedef struct x86_def_t { > +typedef struct X86CPUDefinition { > const char *name; > uint32_t level; > uint32_t xlevel; > @@ -497,7 +497,7 @@ typedef struct x86_def_t { > FeatureWordArray features; > char model_id[48]; > bool cache_info_passthrough; > -} x86_def_t; > +} X86CPUDefinition; > > #define I486_FEATURES (CPUID_FP87 | CPUID_VME | CPUID_PSE) > #define PENTIUM_FEATURES (I486_FEATURES | CPUID_DE | CPUID_TSC | \ > @@ -549,7 +549,7 @@ typedef struct x86_def_t { > > /* built-in CPU model definitions > */ > -static x86_def_t builtin_x86_defs[] = { > +static X86CPUDefinition builtin_x86_defs[] = { > { > .name = "qemu64", > .level = 4, > @@ -1108,7 +1108,7 @@ static x86_def_t builtin_x86_defs[] = { > void x86_cpu_compat_set_features(const char *cpu_model, FeatureWord w, > uint32_t feat_add, uint32_t feat_remove) > { > - x86_def_t *def; > + X86CPUDefinition *def; > int i; > for (i = 0; i < ARRAY_SIZE(builtin_x86_defs); i++) { > def = &builtin_x86_defs[i]; > @@ -1134,12 +1134,12 @@ static int cpu_x86_fill_model_id(char *str) > return 0; > } > > -/* Fill a x86_def_t struct with information about the host CPU, and > +/* Fill a X86CPUDefinition struct with information about the host CPU, and > * the CPU features supported by the host hardware + host kernel > * > * This function may be called only if KVM is enabled. > */ > -static void kvm_cpu_fill_host(x86_def_t *x86_cpu_def) > +static void kvm_cpu_fill_host(X86CPUDefinition *x86_cpu_def) > { > KVMState *s = kvm_state; > uint32_t eax = 0, ebx = 0, ecx = 0, edx = 0; > @@ -1582,10 +1582,10 @@ static PropertyInfo qdev_prop_spinlocks = { > .set = x86_set_hv_spinlocks, > }; > > -static int cpu_x86_find_by_name(X86CPU *cpu, x86_def_t *x86_cpu_def, > +static int cpu_x86_find_by_name(X86CPU *cpu, X86CPUDefinition *x86_cpu_def, > const char *name) > { > - x86_def_t *def; > + X86CPUDefinition *def; > int i; > > if (name == NULL) { > @@ -1753,7 +1753,7 @@ static void listflags(char *buf, int bufsize, uint32_t fbits, > /* generate CPU information. */ > void x86_cpu_list(FILE *f, fprintf_function cpu_fprintf) > { > - x86_def_t *def; > + X86CPUDefinition *def; > char buf[256]; > int i; > > @@ -1780,7 +1780,7 @@ void x86_cpu_list(FILE *f, fprintf_function cpu_fprintf) > CpuDefinitionInfoList *arch_query_cpu_definitions(Error **errp) > { > CpuDefinitionInfoList *cpu_list = NULL; > - x86_def_t *def; > + X86CPUDefinition *def; > int i; > > for (i = 0; i < ARRAY_SIZE(builtin_x86_defs); i++) { > @@ -1822,7 +1822,7 @@ static void filter_features_for_kvm(X86CPU *cpu) > static void x86_cpu_load_def(X86CPU *cpu, const char *name, Error **errp) > { > CPUX86State *env = &cpu->env; > - x86_def_t def1, *def = &def1; > + X86CPUDefinition def1, *def = &def1; > > memset(def, 0, sizeof(*def)); > > @@ -1849,7 +1849,7 @@ static void x86_cpu_load_def(X86CPU *cpu, const char *name, Error **errp) > > object_property_set_str(OBJECT(cpu), def->model_id, "model-id", errp); > > - /* Special cases not set in the x86_def_t structs: */ > + /* Special cases not set in the X86CPUDefinition structs: */ > if (kvm_enabled()) { > env->features[FEAT_KVM] |= kvm_default_features; > } > @@ -1971,7 +1971,7 @@ void x86_cpudef_setup(void) > static const char *model_with_versions[] = { "qemu32", "qemu64", "athlon" }; > > for (i = 0; i < ARRAY_SIZE(builtin_x86_defs); ++i) { > - x86_def_t *def = &builtin_x86_defs[i]; > + X86CPUDefinition *def = &builtin_x86_defs[i]; > > /* Look for specific "cpudef" models that */ > /* have the QEMU version in .model_id */ > Reviewed-by: Paolo Bonzini