From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57645)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1W9Hlt-0007H7-B1
	for qemu-devel@nongnu.org; Fri, 31 Jan 2014 12:20:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1W9Hlo-0007pC-DY
	for qemu-devel@nongnu.org; Fri, 31 Jan 2014 12:20:53 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23987)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1W9Hlo-0007p6-0B
	for qemu-devel@nongnu.org; Fri, 31 Jan 2014 12:20:48 -0500
Message-ID: <52EBDB6A.8000800@redhat.com>
Date: Fri, 31 Jan 2014 10:20:42 -0700
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <fd91a5bb6e9a10f9b5adf332bd66953bf4a75578.1391186851.git.mkletzan@redhat.com>
In-Reply-To: <fd91a5bb6e9a10f9b5adf332bd66953bf4a75578.1391186851.git.mkletzan@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="jtaoisX7KXS7iQvPUiSP6QneKdeQhFfU8"
Subject: Re: [Qemu-devel] [PATCH v2] qmp: expose list of supported character
	device backends
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Martin Kletzander <mkletzan@redhat.com>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Luiz Capitulino <lcapitulino@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--jtaoisX7KXS7iQvPUiSP6QneKdeQhFfU8
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 01/31/2014 09:49 AM, Martin Kletzander wrote:
> Introduce 'query-chardev-backends' QMP command which lists all
> supported character device backends.
>=20
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
> v2:
>  - Version changed from "1.8.0" to "2.0"
>=20
>  qapi-schema.json | 22 ++++++++++++++++++++++
>  qemu-char.c      | 19 +++++++++++++++++++
>  qmp-commands.hx  | 41 +++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 82 insertions(+)

> +
> +-> { "execute": "query-chardev-backends" }
> +<- {
> +      "return":[
> +         {
> +            "name":"udp",
> +         },

Sorry for not noticing earlier, but this is not valid JSON.  Lose the
trailing comma after each "name":"value", since the last element in a
JSON struct is not permitted to have a comma.

> +         {
> +            "name":"tcp",
> +         },
> +         {
> +            "name":"unix",
> +         },
> +         {
> +            "name":"spiceport",
> +         }

With that change to all four spots,

Reviewed-by: Eric Blake <eblake@redhat.com>

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--jtaoisX7KXS7iQvPUiSP6QneKdeQhFfU8
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJS69trAAoJEKeha0olJ0NqwtcH/1xgcspnga3dbdI8F5XsvWTf
x/t50znCk2rijiurHNEmt4jyVs6nGivmLao4E6gG+jro3XlgnaljZYRtdNbFeqDe
NwdQLJ7g4MN0ibD4ySSbCNaOkx9BsNfZugnlNYfwrxRqqK0RXva8kd0OYI6zhL6U
8zwX31uoPTjhOLURC40vgv4sdvRxkoVwsp1kx71Zd13mbmuQozSV4CD0BGIRjdl4
0LgupqGouVx9ZDoeAyhfO6eQFaxFNfmKE0BCR9OX2UkzrzpLSfvFsSYWS59+fFnD
vECjOUAJhSqev5JCd1HpPE48rJdCf2ZboWq0jHpUFybsLUH3+xX6mRlMsj/WkfU=
=RNJH
-----END PGP SIGNATURE-----

--jtaoisX7KXS7iQvPUiSP6QneKdeQhFfU8--