From: Richard Henderson <rth@twiddle.net>
To: Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, mdroth@linux.vnet.ibm.com,
aliguori@amazon.com, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH 2/2] Use g_new() & friends where that makes obvious sense
Date: Fri, 31 Jan 2014 13:13:32 -0600 [thread overview]
Message-ID: <52EBF5DC.5030505@twiddle.net> (raw)
In-Reply-To: <52EBD8F9.4080800@redhat.com>
On 01/31/2014 11:10 AM, Eric Blake wrote:
>
>> > @@ -658,7 +658,7 @@ int qcow2_snapshot_list(BlockDriverState *bs, QEMUSnapshotInfo **psn_tab)
>> > return s->nb_snapshots;
>> > }
>> >
>> > - sn_tab = g_malloc0(s->nb_snapshots * sizeof(QEMUSnapshotInfo));
>> > + sn_tab = g_new0(QEMUSnapshotInfo, s->nb_snapshots);
>> > for(i = 0; i < s->nb_snapshots; i++) {
> Should checkpatch.pl care about the spacing after 'for'? Then again,
> it's unrelated to your conversion, so omitting a whitespace cleanup from
> this patch doesn't hurt.
>
checkpatch.pl won't check lines that aren't touched, as you see here.
r~
next prev parent reply other threads:[~2014-01-31 19:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 15:53 [Qemu-devel] [PATCH 0/2] Use g_new() & friends where that makes obvious sense Markus Armbruster
2014-01-31 15:53 ` [Qemu-devel] [PATCH 1/2] qga: Fix memory allocation pasto Markus Armbruster
2014-01-31 16:06 ` Eric Blake
2014-01-31 15:53 ` [Qemu-devel] [PATCH 2/2] Use g_new() & friends where that makes obvious sense Markus Armbruster
2014-01-31 17:10 ` Eric Blake
2014-01-31 19:13 ` Richard Henderson [this message]
2014-02-03 8:56 ` Markus Armbruster
2014-01-31 16:13 ` [Qemu-devel] [PATCH 0/2] " Peter Maydell
2014-02-03 8:40 ` Markus Armbruster
2014-02-03 9:11 ` Peter Maydell
2014-02-04 16:52 ` Markus Armbruster
2014-02-04 17:27 ` Paolo Bonzini
2014-02-13 16:36 ` Markus Armbruster
2014-02-13 16:48 ` Peter Maydell
2014-02-13 19:30 ` Markus Armbruster
2014-02-18 15:32 ` Markus Armbruster
2014-02-21 11:10 ` Peter Maydell
2014-02-21 11:49 ` Markus Armbruster
2014-02-21 11:52 ` Peter Maydell
2014-02-21 12:37 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EBF5DC.5030505@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).