From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9Jvh-0005h5-CD for qemu-devel@nongnu.org; Fri, 31 Jan 2014 14:39:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W9Jvc-0007P0-Vk for qemu-devel@nongnu.org; Fri, 31 Jan 2014 14:39:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9Jvc-0007Or-N2 for qemu-devel@nongnu.org; Fri, 31 Jan 2014 14:39:04 -0500 Message-ID: <52EBFBD5.5010701@redhat.com> Date: Fri, 31 Jan 2014 12:39:01 -0700 From: Eric Blake MIME-Version: 1.0 References: <20140131190322.GL29329@ERROL.INI.CMU.EDU> In-Reply-To: <20140131190322.GL29329@ERROL.INI.CMU.EDU> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mtRKjSK6wxknPVasd1NcI9MGtdLBohA54" Subject: Re: [Qemu-devel] [RFC PATCH v2] Add option to switch off FDC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" , qemu-devel@nongnu.org Cc: imammedo@redhat.com, mst@redhat.com, lersek@redhat.com, armbru@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mtRKjSK6wxknPVasd1NcI9MGtdLBohA54 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/31/2014 12:03 PM, Gabriel L. Somlo wrote: > Allow guests to omit the configuration of a floppy disk controller. >=20 > Signed-off-by: Gabriel Somlo > --- >=20 > New in this version: >=20 > - "int have_fdc =3D 1;" instead of "int no_fdc =3D 0;" >=20 > - use 8bit field for FDC0's _STA method >=20 >=20 > Are we OK with the "mechanism" part, i.e. introducing "have_fdc", and > programatically configuring the FDC in pc.c and patching the DSDT > based on its value ? >=20 > =20 > +DEF("no-fdc", 0, QEMU_OPTION_no_fdc, > + "-no-fdc disable FDC\n", QEMU_ARCH_I386) > +STEXI > +@item -no-fdc > +@findex -no-fdc > +Disable FDC support. > +ETEXI This is not discoverable via the current state of QMP. It also has the annoyance of being a one-way switch with no way to revert to a default state. Can you make this instead use qemuOpts (maybe looking like '-fdc yes' vs. '-fdc no')? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mtRKjSK6wxknPVasd1NcI9MGtdLBohA54 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS6/vVAAoJEKeha0olJ0NqCZsH/0VpbiYmnXbhsYdu4QeVWFDB 4rTG1aKnQ0yfvH0REieEkf8fkIEhGrWSLB1t+JECB4qcXvXR2tPfR0fNTFv/Cv+M U/OlJo9cijFSAcriBk+iLCcfdRstyCGdfKhk8qLqaG8Sm6eiYZeOKJ53jChTh7SI cwk5AxPCm9H6k4GXULmKmdDblV5++/SZ7ZGRmW7LvA/DV8AnbibgGvbK7ccijixP w0pQiaRAAQVjAj8aifG1e/lxzuFpAs3p1mHVG0y3mGLQ4jNLpYCby/mSNdRzHhe/ iVGxHdX0tr2NpV7Sxdraat+djaV/7RkdvnBlDeOOJ7NSqKyjD0yP0AfB32hY7Wc= =nVqO -----END PGP SIGNATURE----- --mtRKjSK6wxknPVasd1NcI9MGtdLBohA54--