From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42641)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1W9Kwj-0004wn-MC
	for qemu-devel@nongnu.org; Fri, 31 Jan 2014 15:44:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1W9Kwe-0001XQ-Lz
	for qemu-devel@nongnu.org; Fri, 31 Jan 2014 15:44:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42188)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1W9Kwe-0001XM-Ce
	for qemu-devel@nongnu.org; Fri, 31 Jan 2014 15:44:12 -0500
Message-ID: <52EC0B90.6060305@redhat.com>
Date: Fri, 31 Jan 2014 21:46:08 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1391168333-11436-1-git-send-email-pl@kamp.de>	<20140131160720.GC15009@stefanha-thinkpad.redhat.com>	<31A541D2-8EEA-419E-BCFE-995641A78866@kamp.de>
	<CAJSP0QWk7J0XH5CxSB2ev4VR8YhBLJ-3KD+uPCXHivZGyLtmaA@mail.gmail.com>
In-Reply-To: <CAJSP0QWk7J0XH5CxSB2ev4VR8YhBLJ-3KD+uPCXHivZGyLtmaA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv8 0/5] block: add native support for NFS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>, Peter Lieven <pl@kamp.de>
Cc: Kevin Wolf <kwolf@redhat.com>, =?ISO-8859-1?Q?Beno=EEt_Canet?= <benoit.canet@irqsave.net>, Fam Zheng <famz@redhat.com>, ronnie sahlberg <ronniesahlberg@gmail.com>, Jeff Cody <jcody@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Orit Wasserman <owasserm@redhat.com>, Federico Simoncelli <fsimonce@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Wenchao Xia <xiawenc@linux.vnet.ibm.com>

On 31.01.2014 21:41, Stefan Hajnoczi wrote:
> On Fri, Jan 31, 2014 at 6:32 PM, Peter Lieven <pl@kamp.de> wrote:
>> Am 31.01.2014 um 17:07 schrieb Stefan Hajnoczi <stefanha@redhat.com>:
>>
>>> On Fri, Jan 31, 2014 at 12:38:48PM +0100, Peter Lieven wrote:
>>>> This adds v6 of the NFS protocol driver + qemu-iotest adjustments.
>>>>
>>>> v7->v8:
>>>> - bump libnfs requirement to 1.9.2
>>>> - renamed NFSRPC->status to NFSRPC->ret [Benoit]
>>>> - avoid double invocation of nfs_client_close in nfs_file_create [Benoit]
>>>> - fixed error propagation in nfs_file_open [Benoit]
>>> I was able to create a qcow2 image and boot a VM successfully over NFS.
>> This test is obviously new. It is not suitable for protocols other than file as it seems (as a lot
>> of other tests). The file not found error looks like it and not a problem with the driver itself.
>> I think it needs to be adjusted to work with file only for now.
> I think you are right.  Max is the author of the tests, he can confirm
> that the -o file.file.filename= syntax he used and the blkverify
> driver only support the file protocol for now.

Yes, you are correct. Sorry for not checking whether this test is really 
generic, neither regarding the format tested nor the protocol.

Max

> Peter: Please send another revision that restricts protocol to 'file'
> for these tests.  It can be part of the patch that adjusts the other
> test cases.
>
> Stefan