From: Michael Tokarev <mjt@tls.msk.ru>
To: David du Colombier <0intro@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] ide: cmd_exec_dev_diagnostic() always set error register to 0x01
Date: Sat, 01 Feb 2014 13:50:27 +0400 [thread overview]
Message-ID: <52ECC363.3090603@msgid.tls.msk.ru> (raw)
In-Reply-To: <52D6B40D.8080009@msgid.tls.msk.ru>
15.01.2014 20:15, Michael Tokarev wrote:
> 25.12.2013 18:17, David du Colombier wrote:
>> This notably fix IDE CD probing on the Plan 9 operating system,
>> which rely on the error register set by the Execute Device
>> Diagnostic command to detect drive configurations.
>
> While this is a one-liner, I'm not sure it is "trivial enough", just because
> it is not at all obvious we shuold clear error here and not somewhere else.
> I mean, shouldn't s->error be cleared somewhere when next request is queued,
> or something like that?
>
> That's basically why I haven't applied this initially.
>
> CC'ing qemu-devel.
I've applied this to qemu-trivial 3 weeks ago, and now this change has been
applied to the master branch, -- still without any additional comments, which
is somewhat troubling me, but here we go.
Thanks,
/mjt
prev parent reply other threads:[~2014-02-01 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1387981063-14880-1-git-send-email-0intro@gmail.com>
2014-01-15 16:15 ` [Qemu-devel] [Qemu-trivial] [PATCH] ide: cmd_exec_dev_diagnostic() always set error register to 0x01 Michael Tokarev
2014-02-01 9:50 ` Michael Tokarev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52ECC363.3090603@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=0intro@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).