From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Michael Walle <michael@walle.cc>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PULL v4 05/12] milkymist-vgafb: swap pixel data in source buffer
Date: Mon, 03 Feb 2014 09:12:47 +0100 [thread overview]
Message-ID: <52EF4F7F.3010005@redhat.com> (raw)
In-Reply-To: <CAFEAcA_y2jA76GJ9VEPtn7DTQ-90_LVUGqEDY-ZQOX8hP08rCQ@mail.gmail.com>
Il 01/02/2014 18:57, Peter Maydell ha scritto:
>> > In commit fc97bb5ba3e7239c0b6d24095df6784868dfebbf the lduw_raw() call was
>> > eliminated. But we are reading from the target buffer a 16-bit value, which
>> > is in big-endian format. Therefore, swap the bytes if we are building for a
>> > little-endian host.
> Paolo, can you remember why you included this change in that commit?
> It purports to just be moving the display devices around but it seems to
> have included the introduction of this bug, and also a removal of a lduw_raw()
> call from (what is now) hw/display/blizzard_template.h which I suspect is
> also wrong...
>
Most likely it was an incorrectly squashed patch.
Paolo
next prev parent reply other threads:[~2014-02-03 8:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 19:34 [Qemu-devel] [PULL v4 00/12] target-lm32 updates Michael Walle
2014-01-20 19:34 ` [Qemu-devel] [PULL v4 01/12] lm32_sys: increase test case name length limit Michael Walle
2014-02-01 17:39 ` Peter Maydell
2014-01-20 19:34 ` [Qemu-devel] [PULL v4 02/12] tests: lm32: new rule for single test cases Michael Walle
2014-02-01 17:45 ` Peter Maydell
2014-01-20 19:34 ` [Qemu-devel] [PULL v4 03/12] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write() Michael Walle
2014-02-01 17:46 ` Peter Maydell
2014-01-20 19:34 ` [Qemu-devel] [PULL v4 04/12] lm32_uart/lm32_juart: use qemu_chr_fe_write_all() Michael Walle
2014-02-01 17:47 ` Peter Maydell
2014-01-20 19:34 ` [Qemu-devel] [PULL v4 05/12] milkymist-vgafb: swap pixel data in source buffer Michael Walle
2014-02-01 17:57 ` Peter Maydell
2014-02-03 8:12 ` Paolo Bonzini [this message]
2014-01-20 19:34 ` [Qemu-devel] [PULL v4 06/12] target-lm32: kill cpu_abort() calls Michael Walle
2014-01-20 19:34 ` [Qemu-devel] [PULL v4 07/12] target-lm32: move model features to LM32CPU Michael Walle
2014-01-20 19:34 ` [Qemu-devel] [PULL v4 08/12] target-lm32: add breakpoint/watchpoint support Michael Walle
2014-02-01 18:16 ` Peter Maydell
2014-02-03 21:27 ` Richard Henderson
2014-02-03 21:35 ` Peter Maydell
2014-01-20 19:34 ` [Qemu-devel] [PULL v4 09/12] lm32_sys: print test result on stderr Michael Walle
2014-02-01 18:00 ` Peter Maydell
2014-02-01 20:31 ` Michael Walle
2014-02-03 22:39 ` Michael Walle
2014-02-03 22:59 ` Peter Maydell
2014-02-04 18:12 ` Michael Walle
2014-01-20 19:34 ` [Qemu-devel] [PULL v4 10/12] lm32_sys: dump cpu state if test case fails Michael Walle
2014-01-20 19:34 ` [Qemu-devel] [PULL v4 11/12] target-lm32: stop VM on illegal or unknown instruction Michael Walle
2014-02-01 18:06 ` Peter Maydell
2014-02-01 20:53 ` Michael Walle
2014-01-20 19:34 ` [Qemu-devel] [PULL v4 12/12] hw/lm32: print error if cpu model is not found Michael Walle
2014-02-01 18:11 ` Peter Maydell
2014-02-01 18:21 ` [Qemu-devel] [PULL v4 00/12] target-lm32 updates Peter Maydell
2014-02-01 20:56 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EF4F7F.3010005@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@amazon.com \
--cc=michael@walle.cc \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).