From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAHwj-0007ne-Qe for qemu-devel@nongnu.org; Mon, 03 Feb 2014 06:44:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAHwc-0002vT-Ei for qemu-devel@nongnu.org; Mon, 03 Feb 2014 06:44:13 -0500 Received: from cantor2.suse.de ([195.135.220.15]:41727 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAHwc-0002vJ-8J for qemu-devel@nongnu.org; Mon, 03 Feb 2014 06:44:06 -0500 Message-ID: <52EF8103.9030702@suse.de> Date: Mon, 03 Feb 2014 12:44:03 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1391310292-18008-1-git-send-email-edgar.iglesias@gmail.com> <1391310292-18008-2-git-send-email-edgar.iglesias@gmail.com> In-Reply-To: <1391310292-18008-2-git-send-email-edgar.iglesias@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/6] cris: Add a CRISv32 default "any" CPU for user mode emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: edgar.iglesias@gmail.com, qemu-devel@nongnu.org Hi, Am 02.02.2014 04:04, schrieb edgar.iglesias@gmail.com: > From: "Edgar E. Iglesias" >=20 > Signed-off-by: Edgar E. Iglesias > --- > target-cris/cpu.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/target-cris/cpu.c b/target-cris/cpu.c > index 44301a4..21f1860 100644 > --- a/target-cris/cpu.c > +++ b/target-cris/cpu.c > @@ -239,7 +239,14 @@ static const TypeInfo cris_cpu_model_type_infos[] = =3D { > .name =3D TYPE("crisv32"), > .parent =3D TYPE_CRIS_CPU, > .class_init =3D crisv32_cpu_class_init, > + }, > +#if defined(CONFIG_USER_ONLY) > + { > + .name =3D TYPE("any"), > + .parent =3D TYPE_CRIS_CPU, > + .class_init =3D crisv32_cpu_class_init, > } If this model is supposed to be exactly the same as crisv32, I would recommend to make this an alias handled in CRISCPU::class_by_name() rather than a distinct QOM type. Regards, Andreas > +#endif > }; > =20 > #undef TYPE --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg