From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WALnZ-0005by-GZ for qemu-devel@nongnu.org; Mon, 03 Feb 2014 10:51:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WALnT-0008MA-Gd for qemu-devel@nongnu.org; Mon, 03 Feb 2014 10:51:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WALnT-0008M0-2D for qemu-devel@nongnu.org; Mon, 03 Feb 2014 10:50:55 -0500 Message-ID: <52EFBACD.7090802@redhat.com> Date: Mon, 03 Feb 2014 08:50:37 -0700 From: Eric Blake MIME-Version: 1.0 References: <1391440721-25777-1-git-send-email-trent.tong@gmail.com> In-Reply-To: <1391440721-25777-1-git-send-email-trent.tong@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Sc2bHor0GBLF70WQao9pvghAf2jw2KMiE" Subject: Re: [Qemu-devel] [PATCH v4] implementing victim TLB for QEMU system emulated TLB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xin Tong , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, afaerber@suse.de, rth@twiddle.net This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Sc2bHor0GBLF70WQao9pvghAf2jw2KMiE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/03/2014 08:18 AM, Xin Tong wrote: > This patch adds a victim TLB to the QEMU system mode TLB. >=20 > Changes from PATCH v3. > 1. updated measurements - performance improvement is now calculated ove= r 3 runs. > 2. fix code as discussed on the qemu mailing list. Th paragraph above should be moved... >=20 > QEMU system mode page table walks are expensive. Taken by running QEMU > qemu-system-x86_64 system mode on Intel PIN , a TLB miss and walking a > 4-level page tables in guest Linux OS takes ~450 X86 instructions on > average. >=20 =2E.. >=20 > Although there are measurement fluctuations, the performance > improvement is very significant and by no means in the range of > noises. >=20 > Signed-off-by: Xin Tong >=20 > --- =2E..here, after the ---. It is nice information for the reviewers, but has no bearing on the commit itself once accepted into git (a year from now, we won't care how many versions it took to get to the one version that was committed). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Sc2bHor0GBLF70WQao9pvghAf2jw2KMiE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS77rNAAoJEKeha0olJ0NqJu0H/1VbZxfocqoEY/PJk1wX9OeQ WqmJZRQOjMKbYVYzGgrDWU7JOzUgvD0Yhns+kf2ZukPTvm6260Ess9XpinUCi1VR bwE2kn7jU20/3K4TQBlEQ7OfikrpAS3MgOoHbXR9lGg5r73eesz7gYHLeI5qG6dG oeplq38jkDdJ/g6I7Axga43BEngINfj9cR7GsVcZ/J/bf2GPElDb50nNMzgqsCNy gpqqLo9wrQF861cirnORGTUCwFKdXKfC71MqChPxqBdYe02txChsV1b9GwnDF+M2 bAMnd+g7cP+7UjnIHusSwnBjDsxHYuxEk4CKoJfefik/ztLl1eqcPewGnYZBr1M= =Po6P -----END PGP SIGNATURE----- --Sc2bHor0GBLF70WQao9pvghAf2jw2KMiE--