From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAPfM-0008TV-3c for qemu-devel@nongnu.org; Mon, 03 Feb 2014 14:58:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAPfH-0007Jg-7T for qemu-devel@nongnu.org; Mon, 03 Feb 2014 14:58:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:6929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAPfG-0007Jc-Uq for qemu-devel@nongnu.org; Mon, 03 Feb 2014 14:58:43 -0500 Message-ID: <52EFEE3C.10608@redhat.com> Date: Mon, 03 Feb 2014 12:30:04 -0700 From: Eric Blake MIME-Version: 1.0 References: <1391443030-8662-1-git-send-email-imammedo@redhat.com> <1391443030-8662-3-git-send-email-imammedo@redhat.com> In-Reply-To: <1391443030-8662-3-git-send-email-imammedo@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xvtEuwITaE21XNoXGdg2akQtqtnhCmdCE" Subject: Re: [Qemu-devel] [PATCH v5 2/9] qdev: add to BusState "hotplug-handler" link List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, stefanha@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, marcel.a@redhat.com, armbru@redhat.com, blauwirbel@gmail.com, alex.williamson@redhat.com, kraxel@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xvtEuwITaE21XNoXGdg2akQtqtnhCmdCE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/03/2014 08:57 AM, Igor Mammedov wrote: > It will allow to reuse field with different BUSes, > reducing code duplication. Field is intended for > replacing 'hotplug_qdev' field in PCIBus and also > will allow to avoid adding equivalent field to > DimmBus with possiblitity to refactor other BUSes > to use it instead of custom field. > In addition once all users of allow_hotplug field > are converted to new API, link could replace > allow_hotplug field in qdev hotplug code. >=20 > +static inline void qbus_set_hotplug_handler(BusState *bus, DeviceState= *handler, > + Error **errp) > +{ > + object_property_set_link(OBJECT(bus), OBJECT(handler), > + QDEV_HOTPLUG_HANDLER_PROPERTY, errp); > + bus->allow_hotplug =3D 1; Should we convert allow_hotplug to bool over the course of this series? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xvtEuwITaE21XNoXGdg2akQtqtnhCmdCE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS7+48AAoJEKeha0olJ0Nq7TYH/RUk4SNUIDpV2LRTLxBmuftv q1E6onLzFAYhBNVLEDmhSsxUN30oHn5QhXlA5ggszScMReUL7xZSqsVK6ygjTOQ2 kWMDrCUYbPWIdA2/qpynCtEzQPLRrVjrYo1FFP6k9fakIoPy//KeK+u1Xjqj4d6L NNz9vq7eX5keTZNU8iszNddCIQA4aDTZEwXlnWC/mKyKxYJC29E6Rl530/VuHmlx 42Rk6dN9eo35a5dGOongvbkl9UBEIUjsa+wm5XfpoLVeYMGMnos98qc8jQh55GHi x14ARlddmliVm+Bj0efZeu2FKebSwJe7F9qTnqmCT3EUeHqZ/gQ2Qk8brgRZX/k= =XD9A -----END PGP SIGNATURE----- --xvtEuwITaE21XNoXGdg2akQtqtnhCmdCE--