From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAPIH-0005kh-Rc for qemu-devel@nongnu.org; Mon, 03 Feb 2014 14:35:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAPID-0000LV-0U for qemu-devel@nongnu.org; Mon, 03 Feb 2014 14:34:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAPIC-0000LP-BE for qemu-devel@nongnu.org; Mon, 03 Feb 2014 14:34:52 -0500 Message-ID: <52EFEF54.2010800@redhat.com> Date: Mon, 03 Feb 2014 12:34:44 -0700 From: Eric Blake MIME-Version: 1.0 References: <1391443030-8662-1-git-send-email-imammedo@redhat.com> <1391443030-8662-7-git-send-email-imammedo@redhat.com> In-Reply-To: <1391443030-8662-7-git-send-email-imammedo@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gaN9Vsx65dqvDXrck2590SMuKvVrhLeuj" Subject: Re: [Qemu-devel] [PATCH v5 6/9] acpi/piix4pm: convert ACPI PCI hotplug to use hotplug-handler API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, stefanha@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, marcel.a@redhat.com, armbru@redhat.com, blauwirbel@gmail.com, alex.williamson@redhat.com, kraxel@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gaN9Vsx65dqvDXrck2590SMuKvVrhLeuj Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/03/2014 08:57 AM, Igor Mammedov wrote: > Split piix4_device_hotplug() into hotplug/unplug callbacks > and register them as "hotplug-handler" interface implementation of > PIIX4_PM device. >=20 > Replace pci_bus_hotplug() wiring with setting link on > PCI BUS "hotplug-handler" property to PIIX4_PM device. >=20 > Signed-off-by: Igor Mammedov > --- > + error_setg(errp, "Not supported bus. Bus doesn't have propery = '" s/Not supported/Unsupported/ s/propery/property/ > + ACPI_PCIHP_PROP_BSEL "' set."); Drop the trailing '.' - most of our error messages omit it on purpose --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --gaN9Vsx65dqvDXrck2590SMuKvVrhLeuj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS7+9UAAoJEKeha0olJ0NqtWMH/0wxFPpKnK4SKB9Grk7Dj0+r h3Qk5ER4diPSZZqQvEGIf17acUGHFYp2Kq1y9i+/uyNSRz9jRmtGCWxEHg33zxXh ujbdE+STl11saPFPTXGCl0/+xUEsydlTr+V0MwIZ77yGtgQjqUxQKYMyJNXTC83n LkINaPZhFAEJM0QwThofwwaQbv5Dap6dkxZ1EyKidQxGY6Jl0ssZ56jgLd9TXvas 99Q8t/56plxZP0QATGrSNT21PGk5YCZYaEGDSShcet16G1YgwTI3MYET6emo9xwK ZDsJZMkvIzDMTGr91tTerexJ2KtT0VfQeDu/GoLuGMsJMa0cwG+vuq1NaAlk8SM= =nL1s -----END PGP SIGNATURE----- --gaN9Vsx65dqvDXrck2590SMuKvVrhLeuj--