From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAPWk-0004j1-27 for qemu-devel@nongnu.org; Mon, 03 Feb 2014 14:49:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAPWd-0004aE-J7 for qemu-devel@nongnu.org; Mon, 03 Feb 2014 14:49:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:6217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAPWd-0004a2-C0 for qemu-devel@nongnu.org; Mon, 03 Feb 2014 14:49:47 -0500 Message-ID: <52EFF35A.1050606@redhat.com> Date: Mon, 03 Feb 2014 20:51:54 +0100 From: Max Reitz MIME-Version: 1.0 References: <1391454712-14353-1-git-send-email-benoit.canet@irqsave.net> <1391454712-14353-11-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1391454712-14353-11-git-send-email-benoit.canet@irqsave.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V14 10/13] quorum: Add quorum_co_flush(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , stefanha@redhat.com On 03.02.2014 20:11, Beno=C3=AEt Canet wrote: > From: Beno=C3=AEt Canet > > Makes a vote to select error if any. > > Signed-off-by: Benoit Canet > --- > block/quorum.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) See my reply to V10: You're only counting results which are not 0 (i.e.,=20 errors); therefore, 0 will never reach majority. If "error" is set to=20 true (that is, if any error occured), "error_votes" will only contain=20 values below 0 (i.e., errors), therefore, in that case, an error will be=20 returned, regardless of how many calls succeeded. Max