From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAQTJ-0005jV-92 for qemu-devel@nongnu.org; Mon, 03 Feb 2014 15:50:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAQTE-0005nO-0C for qemu-devel@nongnu.org; Mon, 03 Feb 2014 15:50:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:6079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAQTD-0005nJ-MF for qemu-devel@nongnu.org; Mon, 03 Feb 2014 15:50:19 -0500 Message-ID: <52F000FA.9060408@redhat.com> Date: Mon, 03 Feb 2014 13:50:02 -0700 From: Eric Blake MIME-Version: 1.0 References: <1391443030-8662-1-git-send-email-imammedo@redhat.com> <1391443030-8662-3-git-send-email-imammedo@redhat.com> <52EFEE3C.10608@redhat.com> <20140203213828.38f1fac6@thinkpad> In-Reply-To: <20140203213828.38f1fac6@thinkpad> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UefpUO1TcPo3lLAenb3tjUkqf2tAIKw8D" Subject: Re: [Qemu-devel] [PATCH v5 2/9] qdev: add to BusState "hotplug-handler" link List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: kwolf@redhat.com, peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, stefanha@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, marcel.a@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, alex.williamson@redhat.com, kraxel@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UefpUO1TcPo3lLAenb3tjUkqf2tAIKw8D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/03/2014 01:38 PM, Igor Mammedov wrote: >>> +static inline void qbus_set_hotplug_handler(BusState *bus, DeviceSta= te *handler, >>> + Error **errp) >>> +{ >>> + object_property_set_link(OBJECT(bus), OBJECT(handler), >>> + QDEV_HOTPLUG_HANDLER_PROPERTY, errp); >>> + bus->allow_hotplug =3D 1; >> >> Should we convert allow_hotplug to bool over the course of this series= ? > There isn't much point in touching it, since it's going to be removed o= nce > all hotplug-able buses are converted to new interface. After finishing my read through your series, I noticed that you were using allow_hotplug less and less and instead using a new bool in most code you added. Does that just mean your series didn't touch every last client of the old interface, and that there still remains code to be converted, where this series serves as the example of how? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UefpUO1TcPo3lLAenb3tjUkqf2tAIKw8D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS8AD6AAoJEKeha0olJ0NqfN4H/RiJe3fYOdTRAd9zCfU9tx5I yrdCGLOC+l6Nu5eIYw1tMlT8TuWmV6/acwY6U63sT38SFrXAtOUleHOfkW7OCL7q A6sOzJOnZCel8wppRKVPh4Fr4vUZBuh6nJ9sqD6sftVSTaCQYQpgYObWvxCJU4vU j2VE5muS0hYaHPFv7Iw1ZZkXpDJnD/9rZnooRdMFFQFzvoFG1nat5WBspIAFKt4R PjReH489M75ng9uVl5KQ77As2sv71k5SKrqz3VdTsmOxYT0w3WtsgZwQFx2NC7uq vh5wNIummdBygUy0axyNDltRG9XMDTW4HA4sWMPJWAoM+ZiSAxtWxq5u2qbTmq0= =JxP5 -----END PGP SIGNATURE----- --UefpUO1TcPo3lLAenb3tjUkqf2tAIKw8D--