From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAR3t-0006af-4g for qemu-devel@nongnu.org; Mon, 03 Feb 2014 16:28:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAR3i-0000eq-W7 for qemu-devel@nongnu.org; Mon, 03 Feb 2014 16:28:13 -0500 Received: from mail-qa0-x230.google.com ([2607:f8b0:400d:c00::230]:56376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAR3i-0000em-QR for qemu-devel@nongnu.org; Mon, 03 Feb 2014 16:28:02 -0500 Received: by mail-qa0-f48.google.com with SMTP id f11so11013767qae.35 for ; Mon, 03 Feb 2014 13:28:02 -0800 (PST) Sender: Richard Henderson Message-ID: <52F009DB.3080207@twiddle.net> Date: Mon, 03 Feb 2014 13:27:55 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1390246471-25167-1-git-send-email-michael@walle.cc> <1390246471-25167-9-git-send-email-michael@walle.cc> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v4 08/12] target-lm32: add breakpoint/watchpoint support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Michael Walle Cc: QEMU Developers , Anthony Liguori On 02/01/2014 10:16 AM, Peter Maydell wrote: > This looks at least superficially OK, but I'm not really familiar > with QEMU's breakpoint/watchpoint support code. RTH: do > you want to have a look over this one? It's copied verbatim from the i386 port, missing braces and all. So it certainly passes the sniff test. r~