From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58952)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chrisj@rtems.org>) id 1WASRj-0001LL-Br
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 17:57:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chrisj@rtems.org>) id 1WASRc-0002JY-P6
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 17:56:55 -0500
Received: from nskntmtas05p.mx.bigpond.com ([61.9.168.149]:51923)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chrisj@rtems.org>) id 1WASRc-0002JS-CD
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 17:56:48 -0500
Message-ID: <52F01EA6.2030406@rtems.org>
Date: Tue, 04 Feb 2014 09:56:38 +1100
From: Chris Johns <chrisj@rtems.org>
MIME-Version: 1.0
References: <1391401575-52256-1-git-send-email-chrisj@rtems.org>
	<20140203102959.GA10408@redhat.com>
In-Reply-To: <20140203102959.GA10408@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: use glib in glib pkg-config
	check.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org

On 3/02/2014 9:29 pm, Daniel P. Berrange wrote:
> On Mon, Feb 03, 2014 at 03:26:15PM +1100, Chris Johns wrote:
>> Building against with a recent glib in a custom prefix fails because
>> the gthread cflags in the pkg-config file do not have the correct path
>> while the glib pc file does.
>>
>> Signed-off-by: Chris Johns <chrisj@rtems.org>
>> ---
>>   configure | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/configure b/configure
>> index b472694..12f730f 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2343,9 +2343,9 @@ if test "$mingw32" = yes; then
>>   else
>>       glib_req_ver=2.12
>>   fi
>> -if $pkg_config --atleast-version=$glib_req_ver gthread-2.0; then
>> -    glib_cflags=`$pkg_config --cflags gthread-2.0`
>> -    glib_libs=`$pkg_config --libs gthread-2.0`
>> +if $pkg_config --atleast-version=$glib_req_ver glib-2.0; then
>> +    glib_cflags=`$pkg_config --cflags glib-2.0`
>> +    glib_libs=`$pkg_config --libs glib-2.0`
>>       LIBS="$glib_libs $LIBS"
>>       libs_qga="$glib_libs $libs_qga"
>>   else
>
> This change will cause  -pthread linker + compiler flag to be lost.
>

I see in gthread-2.0.pc ..

  Libs: -L${libdir} -lgthread-2.0
  Cflags: -D_REENTRANT

and qemu includes 'glib.h'. Without the glib pc flags being used the 
build fails not being able to find 'glib.h'.

I have no idea about the relationship this has with -pthread. Are both 
needed ? It is not a problem on darwin. Qemu is building and running the 
RTEMS testsuite nicely on the arm architecture (with the posted zync 
reset patch).

>
> What glib version are you seeing a problem with ?

glib-2.39.3 on darwin 13.0.2 (Mavrick).

> It seems we should
> really fix glib, since this will affect countless 1000's of apps using
> it, not try to workaround in all downstream apps.

This is outside of my field of view; to me it still looks qemu specific.

Chris