From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAVOR-0004fs-T4 for qemu-devel@nongnu.org; Mon, 03 Feb 2014 21:05:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAVOL-00068O-Sm for qemu-devel@nongnu.org; Mon, 03 Feb 2014 21:05:43 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:41408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAVOL-000689-MT for qemu-devel@nongnu.org; Mon, 03 Feb 2014 21:05:37 -0500 Received: by mail-pa0-f54.google.com with SMTP id fa1so7901164pad.27 for ; Mon, 03 Feb 2014 18:05:36 -0800 (PST) Message-ID: <52F04AEA.4070207@ozlabs.ru> Date: Tue, 04 Feb 2014 13:05:30 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1391464382-60634-1-git-send-email-agraf@suse.de> In-Reply-To: <1391464382-60634-1-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: KVM: Don't tell the user about missing SPR syncs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org On 02/04/2014 08:53 AM, Alexander Graf wrote: > We sync a lot of SPRs automatically between KVM and QEMU now. Some > of these only matter on newer hardware, some only matter on HV KVM. > > With the current code runnign on my reasonably recent PR KVM kernel > I get a lot of SPR synchronization warnings though: > > $ ./ppc64-softmmu/qemu-system-ppc64 -nographic -enable-kvm > Warning: Unable to set SPR 17 to KVM: Invalid argument > Warning: Unable to set SPR 29 to KVM: Invalid argument > Warning: Unable to set SPR 157 to KVM: Invalid argument > Warning: Unable to set SPR 308 to KVM: Invalid argument > Warning: Unable to set SPR 309 to KVM: Invalid argument > Warning: Unable to set SPR 318 to KVM: Invalid argument > Warning: Unable to set SPR 770 to KVM: Invalid argument > Warning: Unable to set SPR 945 to KVM: Invalid argument > Warning: Unable to set SPR 946 to KVM: Invalid argument > Warning: Unable to set SPR 1013 to KVM: Invalid argument > Warning: Unable to set SPR 17 to KVM: Invalid argument > Warning: Unable to set SPR 29 to KVM: Invalid argument > Warning: Unable to set SPR 157 to KVM: Invalid argument > Warning: Unable to set SPR 308 to KVM: Invalid argument > Warning: Unable to set SPR 309 to KVM: Invalid argument > Warning: Unable to set SPR 318 to KVM: Invalid argument > Warning: Unable to set SPR 770 to KVM: Invalid argument > Warning: Unable to set SPR 945 to KVM: Invalid argument > Warning: Unable to set SPR 946 to KVM: Invalid argument > Warning: Unable to set SPR 1013 to KVM: Invalid argument > > Eventually we want to have something like a "verbose" flag that allows > us to get these warnings when we see something goes wrong. But until > then they do more harm than good exposed to casual users, so let's move > them to debug prints. Why are not these tracepoints? Then we would not need any "verbose" flag. > > Signed-off-by: Alexander Graf > --- > target-ppc/kvm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c > index 8f3f0bf..dce2156 100644 > --- a/target-ppc/kvm.c > +++ b/target-ppc/kvm.c > @@ -480,7 +480,7 @@ static void kvm_get_one_spr(CPUState *cs, uint64_t id, int spr) > > ret = kvm_vcpu_ioctl(cs, KVM_GET_ONE_REG, ®); > if (ret != 0) { > - fprintf(stderr, "Warning: Unable to retrieve SPR %d from KVM: %s\n", > + DPRINTF("Warning: Unable to retrieve SPR %d from KVM: %s\n", > spr, strerror(errno)); > } else { > switch (id & KVM_REG_SIZE_MASK) { > @@ -529,7 +529,7 @@ static void kvm_put_one_spr(CPUState *cs, uint64_t id, int spr) > > ret = kvm_vcpu_ioctl(cs, KVM_SET_ONE_REG, ®); > if (ret != 0) { > - fprintf(stderr, "Warning: Unable to set SPR %d to KVM: %s\n", > + DPRINTF("Warning: Unable to set SPR %d to KVM: %s\n", > spr, strerror(errno)); > } > } > -- Alexey