From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAjdk-0003Nj-TL for qemu-devel@nongnu.org; Tue, 04 Feb 2014 12:21:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAipU-0001fJ-ME for qemu-devel@nongnu.org; Tue, 04 Feb 2014 11:30:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAipU-0001eY-CM for qemu-devel@nongnu.org; Tue, 04 Feb 2014 11:26:32 -0500 Message-ID: <52F114B5.1080607@redhat.com> Date: Tue, 04 Feb 2014 09:26:29 -0700 From: Eric Blake MIME-Version: 1.0 References: <1391527185-28349-1-git-send-email-quintela@redhat.com> <1391527185-28349-6-git-send-email-quintela@redhat.com> In-Reply-To: <1391527185-28349-6-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CQsgpNskN29Ij0ng4WgfL056gMMgeJdp9" Subject: Re: [Qemu-devel] [PATCH 5/8] XBZRLE cache size should not be larger than guest memory size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: Orit Wasserman , anthony@codemonkey.ws This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CQsgpNskN29Ij0ng4WgfL056gMMgeJdp9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/04/2014 08:19 AM, Juan Quintela wrote: > From: Orit Wasserman >=20 > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- > migration.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/migration.c b/migration.c > index 46a7305..25add6f 100644 > --- a/migration.c > +++ b/migration.c > @@ -479,6 +479,13 @@ void qmp_migrate_set_cache_size(int64_t value, Err= or **errp) > return; > } >=20 > + /* Cache should not be larger than guest ram size */ > + if (value > ram_bytes_total()) { > + error_set(errp, QERR_INVALID_PARAMETER_VALUE, "cache size", > + "exceeds guest ram size "); Trailing space in the error message. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CQsgpNskN29Ij0ng4WgfL056gMMgeJdp9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS8RS1AAoJEKeha0olJ0Nqjn0H/AmOFQU4rBbTw/ft6vbe61Bi 1QgUu0xvVXdT3jSua7oOTpSYcl47EmdBhgl5m6Na0EukgdSE8/OX1ALlvPs8T6ep tgTj4E0Z+JfOyU3GmwedZ97BUEkCNIDKJXqautscIEfkKcLkebydMSfPYwh6TvuX //8+m54kD4WkF/yD870La/W26Que7G++SyYNg0PIjuIMRqDL1I+/Z6uY0RIZlFiV biXCK1zoLguFBYvOCsmnqWHhIE4+KsR99dbGORi+HN4FpMO7ZYB4/9/ukC4+9R8z Cw4LUv21owyJ8DqSNE2lOlGWGTWEGBnt9EJ8Y+fJIz8ToLq8EFFupsPz6aloBlA= =QElM -----END PGP SIGNATURE----- --CQsgpNskN29Ij0ng4WgfL056gMMgeJdp9--