From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54854)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1WAjZH-0002p0-Q0
	for qemu-devel@nongnu.org; Tue, 04 Feb 2014 12:18:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1WAisB-00024S-TP
	for qemu-devel@nongnu.org; Tue, 04 Feb 2014 11:32:35 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49460)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1WAisB-000245-M7
	for qemu-devel@nongnu.org; Tue, 04 Feb 2014 11:29:19 -0500
Message-ID: <52F11580.4080004@redhat.com>
Date: Tue, 04 Feb 2014 18:29:52 +0200
From: Orit Wasserman <owasserm@redhat.com>
MIME-Version: 1.0
References: <1391527185-28349-1-git-send-email-quintela@redhat.com>
	<1391527185-28349-6-git-send-email-quintela@redhat.com>
	<52F114B5.1080607@redhat.com>
In-Reply-To: <52F114B5.1080607@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/8] XBZRLE cache size should not be larger
 than guest memory size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: anthony@codemonkey.ws

On 02/04/2014 06:26 PM, Eric Blake wrote:
> On 02/04/2014 08:19 AM, Juan Quintela wrote:
>> From: Orit Wasserman <owasserm@redhat.com>
>>
>> Signed-off-by: Orit Wasserman <owasserm@redhat.com>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>>   migration.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/migration.c b/migration.c
>> index 46a7305..25add6f 100644
>> --- a/migration.c
>> +++ b/migration.c
>> @@ -479,6 +479,13 @@ void qmp_migrate_set_cache_size(int64_t value, Error **errp)
>>           return;
>>       }
>>
>> +    /* Cache should not be larger than guest ram size */
>> +    if (value > ram_bytes_total()) {
>> +        error_set(errp, QERR_INVALID_PARAMETER_VALUE, "cache size",
>> +                  "exceeds guest ram size ");
>
> Trailing space in the error message.
>

I will send a separate patch to fix this.

Orit