From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51654)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WAnxp-0008Vp-S4
	for qemu-devel@nongnu.org; Tue, 04 Feb 2014 16:55:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WAnxk-0002MC-M3
	for qemu-devel@nongnu.org; Tue, 04 Feb 2014 16:55:29 -0500
Received: from mail-qc0-x22f.google.com ([2607:f8b0:400d:c01::22f]:48805)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WAnxk-0002Ly-Bi
	for qemu-devel@nongnu.org; Tue, 04 Feb 2014 16:55:24 -0500
Received: by mail-qc0-f175.google.com with SMTP id x13so14925155qcv.34
	for <qemu-devel@nongnu.org>; Tue, 04 Feb 2014 13:55:23 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52F161C6.4070603@redhat.com>
Date: Tue, 04 Feb 2014 22:55:18 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1391549456-465-1-git-send-email-mst@redhat.com>
In-Reply-To: <1391549456-465-1-git-send-email-mst@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Sander Eikelenboom <linux@eikelenboom.it>, Anthony Liguori <aliguori@amazon.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>

Il 04/02/2014 22:32, Michael S. Tsirkin ha scritto:
> xenfv has no fwcfg and so does not load acpi from QEMU.
> as such new acpi features don't work.
>
> Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Sander, could you pleas econfirm this works for you?
> Also, Xen really should switch to fw cfg some day ...

Yeah, especially because nowadays "-M pc" works with Xen.  It would be 
nice if fw_cfg could be enabled even for Xen on all machines except the 
legacy "-M xenfv".

Stefano, could you give it a shot now that you'll be soon done with 4.4?

Paolo

>  hw/i386/pc_piix.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index a327d71..1acd2b2 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -793,6 +793,17 @@ static QEMUMachine xenfv_machine = {
>      .max_cpus = HVM_MAX_VCPUS,
>      .default_machine_opts = "accel=xen",
>      .hot_add_cpu = pc_hot_add_cpu,
> +    .compat_props = (GlobalProperty[]) {
> +        /* xenfv has no fwcfg and so does not load acpi from QEMU.
> +         * as such new acpi features don't work.
> +         */
> +        {
> +            .driver   = "PIIX4_PM",
> +            .property = "acpi-pci-hotplug-with-bridge-support",
> +            .value    = "off",
> +        },
> +        { /* end of list */ }
> +    },
>  };
>  #endif
>
>