From: "Andreas Färber" <afaerber@suse.de>
To: Markus Armbruster <armbru@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] tests/Makefile: Run qom-test for every architecture
Date: Wed, 05 Feb 2014 15:00:00 +0100 [thread overview]
Message-ID: <52F243E0.7030802@suse.de> (raw)
In-Reply-To: <8738jzw83t.fsf@blackfin.pond.sub.org>
Am 04.02.2014 10:16, schrieb Markus Armbruster:
> Peter Maydell <peter.maydell@linaro.org> writes:
>
>> Rather than requiring every new architecture to remember to add a line
>> to the Makefile to say that qom-test will work on it, autogenerate
>> the list of supported architectures by looking at the files in
>> default-configs (as configure does), and add qom-test to the
>> test list for all of them automatically.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> Together with Markus' patch for running the test for all known
>> machines for the architecture, this will avoid the problem of
>> coverage being missed because of forgetting to update a whitelist.
>
> I applied this on top of Andreas's rebase of my patch rebased to current
> master. Applies cleanly and works fine.
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Thanks for bringing this one up on my radar again, applied to qom-next
(won't do good without Markus' patch but no harm either):
https://github.com/afaerber/qemu-cpu/commits/qom-next
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-02-05 14:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 16:22 [Qemu-devel] [PATCH] tests/Makefile: Run qom-test for every architecture Peter Maydell
2014-02-04 9:16 ` Markus Armbruster
2014-02-05 14:00 ` Andreas Färber [this message]
2014-03-31 8:10 ` Andreas Färber
2014-03-31 8:28 ` Peter Maydell
2014-03-31 8:33 ` Andreas Färber
2014-03-31 8:42 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F243E0.7030802@suse.de \
--to=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).