From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB5Js-0001zP-Ag for qemu-devel@nongnu.org; Wed, 05 Feb 2014 11:27:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WB5Jn-0000GF-Ad for qemu-devel@nongnu.org; Wed, 05 Feb 2014 11:27:24 -0500 Message-ID: <52F26658.7060902@redhat.com> Date: Wed, 05 Feb 2014 09:27:04 -0700 From: Eric Blake MIME-Version: 1.0 References: <1391196846-12188-1-git-send-email-tommusta@gmail.com> <1391196846-12188-7-git-send-email-tommusta@gmail.com> <1DE1A896-D6CB-4F22-82BC-723B2EA7AA73@suse.de> <52F262FF.4010909@gmail.com> In-Reply-To: <52F262FF.4010909@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9bdVsLLMc7W23WM6cWLqEbn4DcnfagQ11" Subject: Re: [Qemu-devel] [Qemu-ppc] [V2 PATCH 6/9] target-ppc: Load Quadword List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta , Alexander Graf Cc: "list@suse.de:PowerPC" , qemu-devel This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9bdVsLLMc7W23WM6cWLqEbn4DcnfagQ11 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/05/2014 09:12 AM, Tom Musta wrote: > On 2/5/2014 3:43 AM, Alexander Graf wrote: >> I would've expected the compiler to emit a warning at this point becau= se you're declaring variables outside of the beginning of a scope? > Only if you enforce C89 compilation. But qemu requires a C99 compiler, where it is not a warning in gcc unless you enable -Wjump-misses-init and have a goto statement that bypasses the declaration. > I did not see a warning on either of my test platforms (PowerPC/RHEL/GC= C 4.4.7, Intel/Ubuntu/GCC 4.6.3). But I will certainly fix. Whether or not the compiler enforces it, some projects still like to stick to C89 declarations-before-statements, even when otherwise requiring C99 compiler features. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9bdVsLLMc7W23WM6cWLqEbn4DcnfagQ11 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS8mZYAAoJEKeha0olJ0NqCKUH/AxQAxZUSpxhYlwVUa68+JK6 +uMDl/yuq0JoQ5vpiDT1oKq1AtgXMLiRLQQEeeLDG1BKlfqiCVvZo6/uWdNxtIpM qGAM4BAQeGgQy+cUPUotmT9mv3KigHN0N2qVYAPyMpIr5YYgp6Jr1t1FqftFuWDB jv7nYLoXjfOf8rW5Nfx+gmxvOjeSYNpbwgyj8b379KuZrKhmCDB/lmQrcaUVG6L6 zGjOSql/vIBxN7gX7CDagy90xTiEtdHMMUgZ6q6LzlDrB6/7WBCVHiZ0FizV3c8j QjNzKECUeaSNHSyNJxzhZ/4GflDDyWFqqekE6ZXAOY9JWK8eWyJkKAub/rbnTFQ= =XqE4 -----END PGP SIGNATURE----- --9bdVsLLMc7W23WM6cWLqEbn4DcnfagQ11--