From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>,
"Igor Mammedov" <imammedo@redhat.com>,
qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org,
peter.crosthwaite@xilinx.com, aliguori@amazon.com,
mst@redhat.com, jan.kiszka@siemens.com, marcel.a@redhat.com,
armbru@redhat.com, blauwirbel@gmail.com,
alex.williamson@redhat.com, kraxel@redhat.com,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v6 2/9] qdev: add to BusState "hotplug-handler" link
Date: Wed, 05 Feb 2014 17:44:30 +0100 [thread overview]
Message-ID: <52F26A6E.5030000@redhat.com> (raw)
In-Reply-To: <52F25E3B.3050009@suse.de>
Il 05/02/2014 16:52, Andreas Färber ha scritto:
>> > + object_property_add_link(obj, QDEV_HOTPLUG_HANDLER_PROPERTY,
>> > + TYPE_HOTPLUG_HANDLER,
>> > + (Object **)&bus->hotplug_handler, NULL);
> Will/should the user ever change that property? If not, we could drop
> this hunk and change the inline link-setting below to just do it the C
> way. Otherwise it should probably be using &error_abort instead of NULL.
No, they shouldn't. But OTOH it's probably useful in general to _read_
the property, and links handle reference counting nicely too. It's
similar to the parent_bus link.
I think we should add something like getter/setter for links like we
have for object_property_add_str, because in most of the current cases
the link should be read-only.
It should not hold this series, though.
Paolo
next prev parent reply other threads:[~2014-02-05 16:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 15:36 [Qemu-devel] [PATCH v6 0/9] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API Igor Mammedov
2014-02-05 15:36 ` [Qemu-devel] [PATCH v6 1/9] define hotplug interface Igor Mammedov
2014-02-05 15:36 ` [Qemu-devel] [PATCH v6 2/9] qdev: add to BusState "hotplug-handler" link Igor Mammedov
2014-02-05 15:52 ` Andreas Färber
2014-02-05 16:31 ` Igor Mammedov
2014-02-05 16:44 ` Paolo Bonzini [this message]
2014-02-05 15:36 ` [Qemu-devel] [PATCH v6 3/9] qdev: add "hotpluggable" property to Device Igor Mammedov
2014-02-05 15:36 ` [Qemu-devel] [PATCH v6 4/9] hw/acpi: move typeinfo to the file end Igor Mammedov
2014-02-05 15:36 ` [Qemu-devel] [PATCH v6 5/9] qdev:pci: refactor PCIDevice to use generic "hotpluggable" property Igor Mammedov
2014-02-05 15:36 ` [Qemu-devel] [PATCH v6 6/9] acpi/piix4pm: convert ACPI PCI hotplug to use hotplug-handler API Igor Mammedov
2014-02-05 15:36 ` [Qemu-devel] [PATCH v6 7/9] pci/shpc: convert SHPC " Igor Mammedov
2014-02-05 15:36 ` [Qemu-devel] [PATCH v6 8/9] pci/pcie: convert PCIE " Igor Mammedov
2014-02-05 15:36 ` [Qemu-devel] [PATCH v6 9/9] hw/pci: switch to a generic hotplug handling for PCIDevice Igor Mammedov
2014-02-10 9:09 ` [Qemu-devel] [PATCH v6 0/9] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API Michael S. Tsirkin
2014-02-10 9:53 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F26A6E.5030000@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=alex.williamson@redhat.com \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).