From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35466)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WB67N-0002JK-Mr
	for qemu-devel@nongnu.org; Wed, 05 Feb 2014 12:18:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WB67H-0002Bg-OV
	for qemu-devel@nongnu.org; Wed, 05 Feb 2014 12:18:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:22736)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WB67H-0002BQ-Ga
	for qemu-devel@nongnu.org; Wed, 05 Feb 2014 12:18:27 -0500
Message-ID: <52F2725E.6020808@redhat.com>
Date: Wed, 05 Feb 2014 18:18:22 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1391087394-17914-1-git-send-email-pbonzini@redhat.com>
	<1391087394-17914-2-git-send-email-pbonzini@redhat.com>
	<52F27134.9030203@suse.de>
In-Reply-To: <52F27134.9030203@suse.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 01/12] qapi: add size parser to
	StringInputVisitor
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>, qemu-devel@nongnu.org
Cc: armbru@redhat.com, Luiz Capitulino <lcapitulino@redhat.com>

Il 05/02/2014 18:13, Andreas F=E4rber ha scritto:
> > +        error_set(errp, QERR_INVALID_PARAMETER_TYPE, name ? name : "=
null",
> > +                  "size");
>
> error_setg()?

We're still using error_set for existing errors.  In this case, the code=20
is taken from qdev-properties.c.

Paolo

> Otherwise looks fine. CC'ing Luiz.