From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB6JN-0001vD-Q5 for qemu-devel@nongnu.org; Wed, 05 Feb 2014 12:31:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WB6JI-0007Qu-Lk for qemu-devel@nongnu.org; Wed, 05 Feb 2014 12:30:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB6JI-0007QZ-34 for qemu-devel@nongnu.org; Wed, 05 Feb 2014 12:30:52 -0500 Message-ID: <52F27547.4040903@redhat.com> Date: Wed, 05 Feb 2014 10:30:47 -0700 From: Eric Blake MIME-Version: 1.0 References: <1391087394-17914-1-git-send-email-pbonzini@redhat.com> <1391087394-17914-2-git-send-email-pbonzini@redhat.com> <52F27134.9030203@suse.de> <52F2725E.6020808@redhat.com> In-Reply-To: <52F2725E.6020808@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mNju46iCg3VJAwl3fpwNU7Q5FIVhSLB4S" Subject: Re: [Qemu-devel] [PATCH 01/12] qapi: add size parser to StringInputVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: armbru@redhat.com, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mNju46iCg3VJAwl3fpwNU7Q5FIVhSLB4S Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/05/2014 10:18 AM, Paolo Bonzini wrote: > Il 05/02/2014 18:13, Andreas F=C3=A4rber ha scritto: >> > + error_set(errp, QERR_INVALID_PARAMETER_TYPE, name ? name : >> "null", >> > + "size"); >> >> error_setg()? >=20 > We're still using error_set for existing errors. In this case, the cod= e > is taken from qdev-properties.c. error_setg uses the generic category, but here, we specifically want the INVALID_PARAMETER_TYPE category. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mNju46iCg3VJAwl3fpwNU7Q5FIVhSLB4S Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS8nVHAAoJEKeha0olJ0NqtT0H/2mekUiWstm051cpXBt7PrVW wTyD8s4EeKBIFMWT4eXpko7SDKhwf3USJh9ziPujYtpl7SpPbPf7awoQx9KyrTm1 Uk/+OEoniOgcldeCoUO2jOSZE08W0EkV2a9JbQV2zIAxBMqBd0BDO5VRJTZAceU9 FenpK/hVoNI488YRo8xawGiKNU0ioqz5kSi4vbXib7A48oo0hcPGyq92/ngshiNx j5RivMEUhJfr8xIQwA82l04OMCOj3HEBpfk8S9xkqJGHST3qNcKmo1aHVy8kK97S 0378zJX+SPZnO3niYra00wD4MPzW2gSmkph5ei86BnGYgCtR0IPHmL8kmROSIIc= =G3NB -----END PGP SIGNATURE----- --mNju46iCg3VJAwl3fpwNU7Q5FIVhSLB4S--