From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB6dM-0004tK-F5 for qemu-devel@nongnu.org; Wed, 05 Feb 2014 12:51:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WB6dG-0005tn-AL for qemu-devel@nongnu.org; Wed, 05 Feb 2014 12:51:36 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39834 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB6dG-0005tX-3a for qemu-devel@nongnu.org; Wed, 05 Feb 2014 12:51:30 -0500 Message-ID: <52F27A1D.2040504@suse.de> Date: Wed, 05 Feb 2014 18:51:25 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1391621709-15620-1-git-send-email-afaerber@suse.de> <52F2795D.10708@redhat.com> In-Reply-To: <52F2795D.10708@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] scripts: Add qom-tree script as modern equivalent of info qtree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, armbru@redhat.com, aliguori@amazon.com, lcapitulino@redhat.com Am 05.02.2014 18:48, schrieb Paolo Bonzini: > Il 05/02/2014 18:35, Andreas F=C3=A4rber ha scritto: >> Functionally it is a recursive qom-list with qom-get per non-child<> >> property. Some failures needed to be handled, such as trying to read a >> pointer property, which is not representable in QMP. Those print a >> literal "". >> >> Signed-off-by: Andreas F=C3=A4rber >=20 > I don't think it's a modern equivalent of anything. The two are just > different. >=20 > "info qtree" may be focused the old concept of buses, but those buses > aren't going anywhere anytime soon. "info qtree" may also be focused o= n > the old concept of qdev properties (now "static" properties), but that'= s > not something that cannot be fixed. >=20 > So, even though I think this script is a very welcome addition, I don't > think it helps settling the question of what to do with "info qtree". > IMO there's no good reason to exclude busless devices from "info qtree"= , > and it's a bug (of course less severe than crashing, but still a bug) > that the busless nand device doesn't appear there. Don't you see that that is unfixable? We may be able to replace info qtree by an info qom-tree, which does the equivalent of this QMP-based script, but qtree ues a completely different display hierarchy than QOM. Andreas >=20 > We can apply all three patches: >=20 > * qdev_try_create for busless devices (or alternatively abort when > creating the device, qom-test will catch that) >=20 > * add qom-tree >=20 > * nand: Don't use qdev_create() in nand_init() >=20 > and still improve "info qtree" on top. >=20 > Paolo --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg