From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB7Zm-00044r-1o for qemu-devel@nongnu.org; Wed, 05 Feb 2014 13:52:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WB7Ze-0001na-Ds for qemu-devel@nongnu.org; Wed, 05 Feb 2014 13:51:58 -0500 Message-ID: <52F28840.30701@suse.de> Date: Wed, 05 Feb 2014 19:51:44 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1378285521-3230-1-git-send-email-afaerber@suse.de> <1378285521-3230-2-git-send-email-afaerber@suse.de> In-Reply-To: <1378285521-3230-2-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC qom-cpu 01/41] cpu: Turn cpu_has_work() into a CPUClass hook List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Paolo Bonzini Cc: Peter Maydell , Jia Liu , Anthony Green , Alexander Graf , Blue Swirl , Max Filippov , Michael Walle , qemu-ppc , "Edgar E. Iglesias" , Guan Xuetao , Aurelien Jarno , Richard Henderson Am 04.09.2013 11:04, schrieb Andreas F=C3=A4rber: > Default to false. >=20 > Tidy variable naming and inline cast uses while at it. >=20 > Signed-off-by: Andreas F=C3=A4rber If I've re-read the IRC transcript correctly, Paolo objected to patch 03/41 and had doubts about 02/41. I have therefore applied this 01/41 to qom-cpu to crack down on functions new targets need to implement in cpu.h= : https://github.com/afaerber/qemu-cpu/commits/qom-cpu Regards, Andreas > --- > cpu-exec.c | 5 ----- > cpus.c | 2 +- > include/qom/cpu.h | 12 ++++++++++-- > qom/cpu.c | 6 ++++++ > target-alpha/cpu.c | 16 ++++++++++++++++ > target-alpha/cpu.h | 15 --------------- > target-arm/cpu.c | 7 +++++++ > target-arm/cpu.h | 6 ------ > target-cris/cpu.c | 6 ++++++ > target-cris/cpu.h | 5 ----- > target-i386/cpu.c | 15 +++++++++++++++ > target-i386/cpu.h | 14 -------------- > target-lm32/cpu.c | 6 ++++++ > target-lm32/cpu.h | 5 ----- > target-m68k/cpu.c | 6 ++++++ > target-m68k/cpu.h | 5 ----- > target-microblaze/cpu.c | 6 ++++++ > target-microblaze/cpu.h | 5 ----- > target-mips/cpu.c | 30 ++++++++++++++++++++++++++++++ > target-mips/cpu.h | 28 ---------------------------- > target-moxie/cpu.c | 6 ++++++ > target-moxie/cpu.h | 5 ----- > target-openrisc/cpu.c | 7 +++++++ > target-openrisc/cpu.h | 5 ----- > target-ppc/cpu.h | 8 -------- > target-ppc/translate_init.c | 9 +++++++++ > target-s390x/cpu.c | 10 ++++++++++ > target-s390x/cpu.h | 9 --------- > target-sh4/cpu.c | 6 ++++++ > target-sh4/cpu.h | 5 ----- > target-sparc/cpu.c | 10 ++++++++++ > target-sparc/cpu.h | 9 --------- > target-unicore32/cpu.c | 7 +++++++ > target-unicore32/cpu.h | 6 ------ > target-xtensa/cpu.c | 8 ++++++++ > target-xtensa/cpu.h | 7 ------- > 36 files changed, 172 insertions(+), 145 deletions(-) --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg