* Re: [Qemu-devel] [PATCH] loader: document that errno is set
2014-02-05 20:05 [Qemu-devel] [PATCH] loader: document that errno is set Michael S. Tsirkin
@ 2014-02-05 20:03 ` Eric Blake
2014-02-05 20:10 ` Michael S. Tsirkin
0 siblings, 1 reply; 3+ messages in thread
From: Eric Blake @ 2014-02-05 20:03 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: Peter Maydell
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
On 02/05/2014 01:05 PM, Michael S. Tsirkin wrote:
> Document that get_image_size sets errorno
s/errorno/errno/
> on failure.
>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/hw/loader.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] [PATCH] loader: document that errno is set
@ 2014-02-05 20:05 Michael S. Tsirkin
2014-02-05 20:03 ` Eric Blake
0 siblings, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2014-02-05 20:05 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell
Document that get_image_size sets errorno
on failure.
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/loader.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/hw/loader.h b/include/hw/loader.h
index 7a23d6b..91b0122 100644
--- a/include/hw/loader.h
+++ b/include/hw/loader.h
@@ -4,6 +4,13 @@
#include "hw/nvram/fw_cfg.h"
/* loader.c */
+/**
+ * get_image_size: retrieve size of an image file
+ * @filename: Path to the image file
+ *
+ * Returns the size of the image file on success, -1 otherwise.
+ * On error, errno is also set as appropriate.
+ */
int get_image_size(const char *filename);
int load_image(const char *filename, uint8_t *addr); /* deprecated */
int load_image_targphys(const char *filename, hwaddr,
--
MST
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] loader: document that errno is set
2014-02-05 20:03 ` Eric Blake
@ 2014-02-05 20:10 ` Michael S. Tsirkin
0 siblings, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2014-02-05 20:10 UTC (permalink / raw)
To: Eric Blake; +Cc: Peter Maydell, qemu-devel
On Wed, Feb 05, 2014 at 01:03:53PM -0700, Eric Blake wrote:
> On 02/05/2014 01:05 PM, Michael S. Tsirkin wrote:
> > Document that get_image_size sets errorno
>
> s/errorno/errno/
>
> > on failure.
> >
> > Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > include/hw/loader.h | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Fixed in my tree, I won't repost just for this though.
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-05 20:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-05 20:05 [Qemu-devel] [PATCH] loader: document that errno is set Michael S. Tsirkin
2014-02-05 20:03 ` Eric Blake
2014-02-05 20:10 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).