From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBatJ-0006Kd-IC for qemu-devel@nongnu.org; Thu, 06 Feb 2014 21:10:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WBatE-0000MZ-Jj for qemu-devel@nongnu.org; Thu, 06 Feb 2014 21:10:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBatE-0000L5-9b for qemu-devel@nongnu.org; Thu, 06 Feb 2014 21:10:00 -0500 Message-ID: <52F44073.2070901@redhat.com> Date: Thu, 06 Feb 2014 19:09:55 -0700 From: Eric Blake MIME-Version: 1.0 References: <1391697000-5855-1-git-send-email-armbru@redhat.com> <1391697000-5855-2-git-send-email-armbru@redhat.com> In-Reply-To: <1391697000-5855-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MHUq8O7Gw7cxXwuFu9KpTNPjBJkmFx6bk" Subject: Re: [Qemu-devel] [PATCH 01/10] tests/qapi-schema: Actually check successful QMP command response List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, aliguori@amazon.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MHUq8O7Gw7cxXwuFu9KpTNPjBJkmFx6bk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/06/2014 07:29 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/test-qmp-commands.c | 44 ++++++++++++++++++++++++++++++++++++---= ----- > 1 file changed, 36 insertions(+), 8 deletions(-) >=20 > diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c > index 5a3e82a..2416d07 100644 > --- a/tests/test-qmp-commands.c > +++ b/tests/test-qmp-commands.c > @@ -71,6 +71,24 @@ static void test_dispatch_cmd_error(void) > QDECREF(req); > } > =20 > +static QObject * > +test_qmp_dispatch(QDict *req) Doesn't qemu style prefer this all on one line? Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MHUq8O7Gw7cxXwuFu9KpTNPjBJkmFx6bk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS9EBzAAoJEKeha0olJ0NqMw0H/1Ib1T9K6oBbIFG3RvulAIi9 rv0sRDVJ4dyDwyVQbYnfUurVpUy1KiKJIqZu1t+rVrzl+hoOEU5smRRauN68Nj5u Yx2apyqkDI1/LSilbPaT6kqhdpXkEY72MVBrUtQ1LEQXZPnzVoyRmyGNPd8pclJO iRbca2oHmVqaNh3crVDMvaAEpD8f0d5jSpI6XXgOFBCMzkyHybMLosiBHTUYEHaZ G7Cmwy6oZHkAdxFGIQsArEGPqoEcRGtNm7qJoiSz8zh/m/qGW0Oj0SGSDPGsb8s7 9Dv+Q2LFQz8HaiIgyTTLhiZnT1fYf0JxWw75zO1YazMGphmkASNWEWnjDu/bqoQ= =XAyl -----END PGP SIGNATURE----- --MHUq8O7Gw7cxXwuFu9KpTNPjBJkmFx6bk--