From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBbMd-0006lT-Gz for qemu-devel@nongnu.org; Thu, 06 Feb 2014 21:40:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WBbMY-0000Te-Mh for qemu-devel@nongnu.org; Thu, 06 Feb 2014 21:40:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBbMY-0000TX-Cq for qemu-devel@nongnu.org; Thu, 06 Feb 2014 21:40:18 -0500 Message-ID: <52F4478B.2030308@redhat.com> Date: Thu, 06 Feb 2014 19:40:11 -0700 From: Eric Blake MIME-Version: 1.0 References: <1391697000-5855-1-git-send-email-armbru@redhat.com> <1391697000-5855-7-git-send-email-armbru@redhat.com> In-Reply-To: <1391697000-5855-7-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OIqQm1ER1jwvdpaAjvW8G1jAlD1BdBjMB" Subject: Re: [Qemu-devel] [PATCH 06/10] tests/qapi-schema: Cover union types with base List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, aliguori@amazon.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OIqQm1ER1jwvdpaAjvW8G1jAlD1BdBjMB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/06/2014 07:29 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/qapi-schema/qapi-schema-test.json | 1 + > tests/qapi-schema/qapi-schema-test.out | 2 +- > tests/test-qmp-input-strict.c | 4 ++-- > tests/test-qmp-input-visitor.c | 3 ++- > tests/test-qmp-output-visitor.c | 2 ++ > 5 files changed, 8 insertions(+), 4 deletions(-) >=20 > - OrderedDict([('union', 'UserDefUnion'), ('data', OrderedDict([('a', '= UserDefA'), ('b', 'UserDefB')]))]), > + OrderedDict([('union', 'UserDefUnion'), ('base', 'UserDefZero'), ('da= ta', OrderedDict([('a', 'UserDefA'), ('b', 'UserDefB')]))]), > OrderedDict([('union', 'UserDefAnonUnion'), ('discriminator', Ordered= Dict()), ('data', OrderedDict([('uda', 'UserDefA'), ('s', 'str'), ('i', '= int')]))]), > OrderedDict([('union', 'UserDefNativeListUnion'), ('data', OrderedDic= t([('integer', ['int']), ('s8', ['int8']), ('s16', ['int16']), ('s32', ['= int32']), ('s64', ['int64']), ('u8', ['uint8']), ('u16', ['uint16']), ('u= 32', ['uint32']), ('u64', ['uint64']), ('number', ['number']), ('boolean'= , ['bool']), ('string', ['str'])]))]), Good, we still have coverage of a union without a base. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OIqQm1ER1jwvdpaAjvW8G1jAlD1BdBjMB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS9EeLAAoJEKeha0olJ0NqvGsIAItyQgkow789uCfjE09z2BHZ aTCpo1xPAZCfn7Ds1NSBY0HpAz64BHzCmjgHFUmPOZ4rQ0f1jP89CvmW8LaF9/uI 2IqmGHoUSBjY52npYLu/xEwIXv9lhKQO3rjq3f/C2G1fQMQA3lEthl/fmGgtHkSH hmfSbelm05QC/jpOC5ucie17NIEFwOluFSDPqqssf0r+ljMlwfetEHwO6fjmvHDM yVXnJ6ygMuE/U/SkLt7MUyWPoC2RzwrOXS9m+xLRFZRrk6eC5Q6/RZAv/a6p+Zic TEU4BuJoBjhdOagucKAZNQ+yGonALSnN7ig15MEdggh5+7S5ZBa3EgGoOO+6g84= =Dua5 -----END PGP SIGNATURE----- --OIqQm1ER1jwvdpaAjvW8G1jAlD1BdBjMB--