From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBbXg-0000Gz-CD for qemu-devel@nongnu.org; Thu, 06 Feb 2014 21:51:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WBbXb-0003Mi-GV for qemu-devel@nongnu.org; Thu, 06 Feb 2014 21:51:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBbXb-0003Lj-6x for qemu-devel@nongnu.org; Thu, 06 Feb 2014 21:51:43 -0500 Message-ID: <52F44A3A.50204@redhat.com> Date: Thu, 06 Feb 2014 19:51:38 -0700 From: Eric Blake MIME-Version: 1.0 References: <1391697000-5855-1-git-send-email-armbru@redhat.com> <1391697000-5855-8-git-send-email-armbru@redhat.com> In-Reply-To: <1391697000-5855-8-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Phl5BdVsHsQNM76jH6piLT07h6EiG2kL2" Subject: Re: [Qemu-devel] [PATCH 07/10] tests/qapi-schema: Cover flat union types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, aliguori@amazon.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Phl5BdVsHsQNM76jH6piLT07h6EiG2kL2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/06/2014 07:29 AM, Markus Armbruster wrote: > The test demonstrates a generator bug: the generated struct > UserDefFlatUnion doesn't include members for the indirect base > UserDefZero. Good catch. >=20 > Signed-off-by: Markus Armbruster > --- > tests/qapi-schema/qapi-schema-test.json | 7 +++++++ > tests/qapi-schema/qapi-schema-test.out | 2 ++ > tests/test-qmp-input-strict.c | 33 +++++++++++++++++++++++++= ++++++++ > tests/test-qmp-input-visitor.c | 20 ++++++++++++++++++++ > tests/test-qmp-output-visitor.c | 31 +++++++++++++++++++++++++= ++++++ > 5 files changed, 93 insertions(+) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Phl5BdVsHsQNM76jH6piLT07h6EiG2kL2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS9Eo6AAoJEKeha0olJ0NqfawIAKXqmL2BR+QrQsrJC3G/aqL5 LGpurinF4dO80KLObwMw3KYkTKBUPvqoDtkTPs1vWogMiXDliFleUhAT4ATjsrsV YMlH+Kju9ufRmDku8ibP3sZju28zD4A0/qjIxbNesnQZcF0HW6x6lP7/hXHk/CxY 3JSRdIb4kSQUrx67ZaXWwZvGgujL7M2LMKMvx0XHcV+by2nwL20vh+k3tRN0lvld dd5Q3Ttr2LdMI2GoRjlJYULtJq93HvjZ6AF6BXg6a6V6UNM/aeTRNOCWddyGvP+D XfAul0UaRIwGWRVgp/EFCiIlTs2LoNxAKJtIPSQF2cGGUaiyhJFqmmXqOxMHL6M= =BdLa -----END PGP SIGNATURE----- --Phl5BdVsHsQNM76jH6piLT07h6EiG2kL2--