From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBbYu-0001A9-2U for qemu-devel@nongnu.org; Thu, 06 Feb 2014 21:53:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WBbYp-0003n8-AX for qemu-devel@nongnu.org; Thu, 06 Feb 2014 21:53:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBbYp-0003n4-1I for qemu-devel@nongnu.org; Thu, 06 Feb 2014 21:52:59 -0500 Message-ID: <52F44A86.4040200@redhat.com> Date: Thu, 06 Feb 2014 19:52:54 -0700 From: Eric Blake MIME-Version: 1.0 References: <1391697000-5855-1-git-send-email-armbru@redhat.com> <1391697000-5855-9-git-send-email-armbru@redhat.com> In-Reply-To: <1391697000-5855-9-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SMfLR602wkOow9cpdWD2vtvFi01eUM5ju" Subject: Re: [Qemu-devel] [PATCH 08/10] qapi: Drop nonsensical header guard in generated qapi-visit.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, aliguori@amazon.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SMfLR602wkOow9cpdWD2vtvFi01eUM5ju Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/06/2014 07:29 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi-visit.py | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Eric Blake >=20 > diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py > index 65f1a54..ff4239c 100644 > --- a/scripts/qapi-visit.py > +++ b/scripts/qapi-visit.py > @@ -494,10 +494,8 @@ fdecl.write(guardend("QAPI_VISIT_BUILTIN_VISITOR_D= ECL")) > # have the functions defined, so we use -b option to provide control > # over these cases > if do_builtins: > - fdef.write(guardstart("QAPI_VISIT_BUILTIN_VISITOR_DEF")) > for typename in builtin_types: > fdef.write(generate_visit_list(typename, None)) > - fdef.write(guardend("QAPI_VISIT_BUILTIN_VISITOR_DEF")) > =20 > for expr in exprs: > if expr.has_key('type'): >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SMfLR602wkOow9cpdWD2vtvFi01eUM5ju Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS9EqGAAoJEKeha0olJ0NqkiUH/0oGKKrRHHmB6vZ1u0ZyVSWD 8/rknOg7Mbo1EBiSW5g2gS5CU/7vefgmCRCSF4hS0MQU7BXsYkg/EasRhiX4o6sK 0hela8++tcoBHFK7P6IqI8Un45cqQG623Z803wmsnej7k3Rty48vCyRdSHkEnCpP k/Z5mhti7GIvwGdhLbTIWz7ICVhFKNkH0A4PKJpeeEEM7IXHeNi5Hq54xYnMawPC Zy52JRVWsorz8KtiMUfM0BWzSA3DV3UcQciE9t4oOoIkfLcvpOFAIsvluQXub6Pj XXNbo4/7rABSy5n+DyDCvUyNJ3L4ZMGv5gEekKOWb08Z/5rrkbW+J4P2kZxiL5E= =eqNs -----END PGP SIGNATURE----- --SMfLR602wkOow9cpdWD2vtvFi01eUM5ju--