From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.net>,
Michael Tokarev <mjt@tls.msk.ru>,
QEMU Developers <qemu-devel@nongnu.org>,
Alex Bligh <alex@alex.org.uk>,
Miroslav Rezanina <mrezanin@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Lluis Vilanova <vilanova@ac.upc.edu>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v18 00/10] Shared library module support
Date: Fri, 07 Feb 2014 08:13:34 +0100 [thread overview]
Message-ID: <52F4879E.7040300@redhat.com> (raw)
In-Reply-To: <CAFEAcA8wDQft-QzNB72J+qhsgeAAwku+WKwRf76rVpax2BQSgQ@mail.gmail.com>
Il 07/02/2014 01:06, Peter Maydell ha scritto:
> Why do we need OS specific code to do this when the code
> in vl.c for getting the executable path to use as a base for
> finding bios blobs works fine without OS specific code?
That's because right now module_call_init is not receiving an argv[0] to
pass to qemu_exec_dir (os_find_datadir has an argument for that). It
can be fixed (in the whole call chain, including e.g.
bdrv_init/bdrv_init_with_whitelist).
However, note that there is OS-specific code already for Linux, FreeBSD
and Windows. Adding Darwin makes sense.
On some BSDs there's also /proc/curproc/file. I don't know _which_ BSDs
have it though.
Paolo
next prev parent reply other threads:[~2014-02-07 7:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 14:49 [Qemu-devel] [PATCH v18 00/10] Shared library module support Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 01/10] util: Split out qemu_exec_dir from os_find_datadir Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 02/10] rules.mak: fix $(obj) to a real relative path Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 03/10] rules.mak: allow per object cflags and libs Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 04/10] block: use per-object " Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 05/10] darwin: do not use -mdynamic-no-pic Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 06/10] rules.mak: introduce DSO rules Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 07/10] module: implement module loading Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 08/10] Makefile: install modules with "make install" Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 09/10] Makefile: introduce common-obj-m and block-obj-m for DSO Paolo Bonzini
2014-01-31 14:49 ` [Qemu-devel] [PATCH v18 10/10] block: convert block drivers linked with libs to modules Paolo Bonzini
2014-02-05 18:19 ` [Qemu-devel] [PATCH v18 00/10] Shared library module support Peter Maydell
2014-02-06 23:38 ` Paolo Bonzini
2014-02-07 0:06 ` Peter Maydell
2014-02-07 7:13 ` Paolo Bonzini [this message]
2014-02-07 8:14 ` Michael Tokarev
2014-02-07 8:38 ` Paolo Bonzini
2014-02-07 8:40 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F4879E.7040300@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex@alex.org.uk \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mrezanin@redhat.com \
--cc=peter.maydell@linaro.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).