From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33220)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WBfdH-0005rG-Nd
	for qemu-devel@nongnu.org; Fri, 07 Feb 2014 02:14:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WBfd5-0005as-NL
	for qemu-devel@nongnu.org; Fri, 07 Feb 2014 02:13:51 -0500
Received: from mail-qc0-x229.google.com ([2607:f8b0:400d:c01::229]:52510)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WBfd5-0005an-If
	for qemu-devel@nongnu.org; Fri, 07 Feb 2014 02:13:39 -0500
Received: by mail-qc0-f169.google.com with SMTP id w7so5278173qcr.0
	for <qemu-devel@nongnu.org>; Thu, 06 Feb 2014 23:13:39 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52F4879E.7040300@redhat.com>
Date: Fri, 07 Feb 2014 08:13:34 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <CAFEAcA_gDgVp7FS97XgSOAzT7MbFkhBVM4OesM0mZo=1MZnQ1Q@mail.gmail.com>	<1391729892-17783-1-git-send-email-pbonzini@redhat.com>
	<CAFEAcA8wDQft-QzNB72J+qhsgeAAwku+WKwRf76rVpax2BQSgQ@mail.gmail.com>
In-Reply-To: <CAFEAcA8wDQft-QzNB72J+qhsgeAAwku+WKwRf76rVpax2BQSgQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v18 00/10] Shared library module support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.net>, Michael Tokarev <mjt@tls.msk.ru>, QEMU Developers <qemu-devel@nongnu.org>, Alex Bligh <alex@alex.org.uk>, Miroslav Rezanina <mrezanin@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Lluis Vilanova <vilanova@ac.upc.edu>, Richard Henderson <rth@twiddle.net>

Il 07/02/2014 01:06, Peter Maydell ha scritto:
> Why do we need OS specific code to do this when the code
> in vl.c for getting the executable path to use as a base for
> finding bios blobs works fine without OS specific code?

That's because right now module_call_init is not receiving an argv[0] to 
pass to qemu_exec_dir (os_find_datadir has an argument for that).  It 
can be fixed (in the whole call chain, including e.g. 
bdrv_init/bdrv_init_with_whitelist).

However, note that there is OS-specific code already for Linux, FreeBSD 
and Windows.  Adding Darwin makes sense.

On some BSDs there's also /proc/curproc/file.  I don't know _which_ BSDs 
have it though.

Paolo